From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: [patch] entry values: Fix resolving in inlined frames
Date: Fri, 05 Oct 2012 16:34:00 -0000 [thread overview]
Message-ID: <20121005163429.GU3028@adacore.com> (raw)
In-Reply-To: <20121005154502.GA2128@host2.jankratochvil.net>
Jan, I am not a native speaker, but I can help you rephrase
some of your comments, if you'd like. I think comments are very
important - in fact one of the most important elements of the code,
because they provide insight as to why we do the things we do.
A testcase is good, but always takes some time to process, and
is ofter after the fact (regression).
FWIW, I don't think your English is generally all that bad.
It's just occasional...
--
Joel
next prev parent reply other threads:[~2012-10-05 16:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 12:41 Jan Kratochvil
2012-10-05 15:18 ` Mark Kettenis
2012-10-05 15:45 ` Jan Kratochvil
2012-10-05 16:34 ` Joel Brobecker [this message]
2012-10-16 8:47 ` [comment commit] " Jan Kratochvil
2012-10-08 9:18 ` Yao Qi
2012-10-15 19:16 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005163429.GU3028@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox