From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31489 invoked by alias); 5 Oct 2012 16:34:51 -0000 Received: (qmail 30615 invoked by uid 22791); 5 Oct 2012 16:34:46 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Oct 2012 16:34:42 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0BEFD1C7FCD; Fri, 5 Oct 2012 12:34:42 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id LnT6hph0-AQF; Fri, 5 Oct 2012 12:34:41 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1793B1C7FC5; Fri, 5 Oct 2012 12:34:41 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id DBB93C54B2; Fri, 5 Oct 2012 18:34:29 +0200 (CEST) Date: Fri, 05 Oct 2012 16:34:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Mark Kettenis , gdb-patches@sourceware.org Subject: Re: [patch] entry values: Fix resolving in inlined frames Message-ID: <20121005163429.GU3028@adacore.com> References: <20121005124107.GA22927@host2.jankratochvil.net> <201210051518.q95FID1J003796@glazunov.sibelius.xs4all.nl> <20121005154502.GA2128@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121005154502.GA2128@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00101.txt.bz2 Jan, I am not a native speaker, but I can help you rephrase some of your comments, if you'd like. I think comments are very important - in fact one of the most important elements of the code, because they provide insight as to why we do the things we do. A testcase is good, but always takes some time to process, and is ofter after the fact (regression). FWIW, I don't think your English is generally all that bad. It's just occasional... -- Joel