From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] entry values: Fix resolving in inlined frames
Date: Fri, 05 Oct 2012 15:45:00 -0000 [thread overview]
Message-ID: <20121005154502.GA2128@host2.jankratochvil.net> (raw)
In-Reply-To: <201210051518.q95FID1J003796@glazunov.sibelius.xs4all.nl>
On Fri, 05 Oct 2012 17:18:13 +0200, Mark Kettenis wrote:
> I realize that you're not a native speaker, but a big part of the
> problem is that there are a lot of grammatical mistakes in your
> english. Can you get some help from a native speaker to make sure the
> comments in the code make sense?
In fact I believe the comment does not explain much more than what the code
says, therefore I will remove the comment. It is best to just remove the code
and see what the testcase does. I at least almost always provide testcases.
While I understand my English may be difficult I do not see a practical way
how to get reviewed all my text. For each text it is for various reasons
a very time consuming process with company text content authors for official
company documents, also I cannot afford paying someone for any text I write.
My texts and code comments are best effort, current GDB codebase usually has
no comments, please skip any of my text if you prefer it that way also like
GDB has been written so far.
Thanks,
Jan
next prev parent reply other threads:[~2012-10-05 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 12:41 Jan Kratochvil
2012-10-05 15:18 ` Mark Kettenis
2012-10-05 15:45 ` Jan Kratochvil [this message]
2012-10-05 16:34 ` Joel Brobecker
2012-10-16 8:47 ` [comment commit] " Jan Kratochvil
2012-10-08 9:18 ` Yao Qi
2012-10-15 19:16 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005154502.GA2128@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox