From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30753 invoked by alias); 5 Oct 2012 15:45:18 -0000 Received: (qmail 30737 invoked by uid 22791); 5 Oct 2012 15:45:16 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Oct 2012 15:45:07 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q95Fj6Sb001822 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 5 Oct 2012 11:45:06 -0400 Received: from host2.jankratochvil.net (ovpn-116-83.ams2.redhat.com [10.36.116.83]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q95Fj2kA027206 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 5 Oct 2012 11:45:05 -0400 Date: Fri, 05 Oct 2012 15:45:00 -0000 From: Jan Kratochvil To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [patch] entry values: Fix resolving in inlined frames Message-ID: <20121005154502.GA2128@host2.jankratochvil.net> References: <20121005124107.GA22927@host2.jankratochvil.net> <201210051518.q95FID1J003796@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201210051518.q95FID1J003796@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00100.txt.bz2 On Fri, 05 Oct 2012 17:18:13 +0200, Mark Kettenis wrote: > I realize that you're not a native speaker, but a big part of the > problem is that there are a lot of grammatical mistakes in your > english. Can you get some help from a native speaker to make sure the > comments in the code make sense? In fact I believe the comment does not explain much more than what the code says, therefore I will remove the comment. It is best to just remove the code and see what the testcase does. I at least almost always provide testcases. While I understand my English may be difficult I do not see a practical way how to get reviewed all my text. For each text it is for various reasons a very time consuming process with company text content authors for official company documents, also I cannot afford paying someone for any text I write. My texts and code comments are best effort, current GDB codebase usually has no comments, please skip any of my text if you prefer it that way also like GDB has been written so far. Thanks, Jan