From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32466 invoked by alias); 8 Oct 2012 09:18:19 -0000 Received: (qmail 32457 invoked by uid 22791); 8 Oct 2012 09:18:17 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Oct 2012 09:18:08 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TL9TR-0005qs-8k from Yao_Qi@mentor.com ; Mon, 08 Oct 2012 02:18:05 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 8 Oct 2012 02:18:04 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Mon, 8 Oct 2012 02:18:09 -0700 Message-ID: <50729A43.9060702@codesourcery.com> Date: Mon, 08 Oct 2012 09:18:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Mark Kettenis CC: , Subject: Re: [patch] entry values: Fix resolving in inlined frames References: <20121005124107.GA22927@host2.jankratochvil.net> <201210051518.q95FID1J003796@glazunov.sibelius.xs4all.nl> In-Reply-To: <201210051518.q95FID1J003796@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00123.txt.bz2 On 10/05/2012 11:18 PM, Mark Kettenis wrote: >> + /* Skip any inlined frames, entry value call sites work between real >> >+ functions. They do not make sense between inline functions as even PC >> >+ does not change there. */ > I realize that you're not a native speaker, but a big part of the > problem is that there are a lot of grammatical mistakes in your > english. Can you get some help from a native speaker to make sure the > comments in the code make sense? I am not an English native speaker either, and I do believe my comments in patches and mails sometimes make troubles to people who read them. However, I get a lot of kindly help from people here to correct or improve them, and I really appreciate their helps. If you find the mistakes, feel free to point them out, or if you can't understand the words, ask the author to clarify. It is impractical, at least for me, to find a native speaker dedicated to polishing comments for me. -- Yao