Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [patch] Fix disassemble without parameters in tailcall frame
Date: Thu, 13 Sep 2012 03:56:00 -0000	[thread overview]
Message-ID: <5051592F.6030701@codesourcery.com> (raw)
In-Reply-To: <20120912153830.GA7317@host2.jankratochvil.net>

On 09/12/2012 11:38 PM, Jan Kratochvil wrote:
> The "=> " PC pointer is now not displayed anywhere which seems correct to me.
>

Right, PC doesn't fall in the range of function b, so "=>" is not displayed.

disassemble^M
Dump of assembler code for function b(int, double):^M
    0x0000000000400520 <+0>:     addsd  0x468(%rip),%xmm0        # 
0x400990^M
    0x0000000000400528 <+8>:     add    $0x2,%edi^M
    0x000000000040052b <+11>:    jmp    0x400500 <c(int, double)>^M
End of assembler dump.^M
(gdb) PASS: gdb.arch/amd64-entry-value.exp: disassemble
p/x $rip^M
$25 = 0x40052d

>
> +# Test $pc adjustment which is now right after the function end.
> +gdb_test "down" "\r\n#2 .*"
> +gdb_test "disassemble" {Dump of assembler code for function b\(int, double\):.*}
> +

Do we need to complete the test here to check 'PC doesn't fall in the 
range of function b' or ' => is not displayed'?

-- 
Yao


  reply	other threads:[~2012-09-13  3:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12 15:38 Jan Kratochvil
2012-09-13  3:56 ` Yao Qi [this message]
2012-09-13  4:17   ` Jan Kratochvil
2012-09-21 19:35     ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5051592F.6030701@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox