[patch] Fix disassemble without parameters in tailcall frame

[Jan Kratochvil <jan.kratochvil@redhat.com>]

Hi,

when the current frame is in tailcall function:

disassemble
No function contains program counter for selected frame.
(gdb) FAIL: gdb.arch/amd64-entry-value.exp: disassemble
->
disassemble
Dump of assembler code for function b(int, double):
   0x0000000000400790 <+0>:     addsd  0x298(%rip),%xmm0        # 0x400a30
   0x0000000000400798 <+8>:     add    $0x2,%edi
   0x000000000040079b <+11>:    jmp    0x400770 <c(int, double)>
End of assembler dump.

Such a simple but annoying to me issue when tailcall frames are common in
practice now.

The "=> " PC pointer is now not displayed anywhere which seems correct to me.

No regressions on {x86_64,x86_64-m32,i686}-fedora18-linux-gnu.


Thanks,
Jan


gdb/
2012-09-12  Jan Kratochvil  <jan.kratochvil@redhat.com>

	Fix disassemble without parameters in tailcall frame.
	* cli/cli-cmds.c (disassemble_current_function): Use
	get_frame_address_in_block.

gdb/testsuite/
2012-09-12  Jan Kratochvil  <jan.kratochvil@redhat.com>

	Fix disassemble without parameters in tailcall frame.
	* gdb.arch/amd64-entry-value.exp (down, disassemble): New tests.

diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c
index d3473d5..0bdd373 100644
--- a/gdb/cli/cli-cmds.c
+++ b/gdb/cli/cli-cmds.c
@@ -1091,7 +1091,7 @@ disassemble_current_function (int flags)
 
   frame = get_selected_frame (_("No frame selected."));
   gdbarch = get_frame_arch (frame);
-  pc = get_frame_pc (frame);
+  pc = get_frame_address_in_block (frame);
   if (find_pc_partial_function (pc, &name, &low, &high) == 0)
     error (_("No function contains program counter for selected frame."));
 #if defined(TUI)
diff --git a/gdb/testsuite/gdb.arch/amd64-entry-value.exp b/gdb/testsuite/gdb.arch/amd64-entry-value.exp
index dd22d42..5ff18bf 100644
--- a/gdb/testsuite/gdb.arch/amd64-entry-value.exp
+++ b/gdb/testsuite/gdb.arch/amd64-entry-value.exp
@@ -213,6 +213,10 @@ gdb_test {p $sp0 == $sp} " = true"
 gdb_test "frame 3" "\r\n#3 .*"
 gdb_test {p $sp0 + sizeof (void *) == $sp} " = true"
 
+# Test $pc adjustment which is now right after the function end.
+gdb_test "down" "\r\n#2 .*"
+gdb_test "disassemble" {Dump of assembler code for function b\(int, double\):.*}
+
 
 # Test partial-ambiguous virtual tail call frames chain.