From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94512-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26765 invoked by alias); 13 Sep 2012 03:56:32 -0000
Received: (qmail 26751 invoked by uid 22791); 13 Sep 2012 03:56:31 -0000
X-SWARE-Spam-Status: No, hits=-4.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL
X-Spam-Check-By: sourceware.org
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Sep 2012 03:56:11 +0000
Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58])	by relay1.mentorg.com with esmtp 	id 1TC0XB-0004Fw-8h from Yao_Qi@mentor.com ; Wed, 12 Sep 2012 20:56:09 -0700
Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675);	 Wed, 12 Sep 2012 20:56:09 -0700
Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Wed, 12 Sep 2012 20:56:08 -0700
Message-ID: <5051592F.6030701@codesourcery.com>
Date: Thu, 13 Sep 2012 03:56:00 -0000
From: Yao Qi <yao@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120717 Thunderbird/14.0
MIME-Version: 1.0
To: Jan Kratochvil <jan.kratochvil@redhat.com>
CC: <gdb-patches@sourceware.org>
Subject: Re: [patch] Fix disassemble without parameters in tailcall frame
References: <20120912153830.GA7317@host2.jankratochvil.net>
In-Reply-To: <20120912153830.GA7317@host2.jankratochvil.net>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00235.txt.bz2

On 09/12/2012 11:38 PM, Jan Kratochvil wrote:
> The "=> " PC pointer is now not displayed anywhere which seems correct to me.
>

Right, PC doesn't fall in the range of function b, so "=>" is not displayed.

disassemble^M
Dump of assembler code for function b(int, double):^M
    0x0000000000400520 <+0>:     addsd  0x468(%rip),%xmm0        # 
0x400990^M
    0x0000000000400528 <+8>:     add    $0x2,%edi^M
    0x000000000040052b <+11>:    jmp    0x400500 <c(int, double)>^M
End of assembler dump.^M
(gdb) PASS: gdb.arch/amd64-entry-value.exp: disassemble
p/x $rip^M
$25 = 0x40052d

>
> +# Test $pc adjustment which is now right after the function end.
> +gdb_test "down" "\r\n#2 .*"
> +gdb_test "disassemble" {Dump of assembler code for function b\(int, double\):.*}
> +

Do we need to complete the test here to check 'PC doesn't fall in the 
range of function b' or ' => is not displayed'?

-- 
Yao