From: Yao Qi <yao@codesourcery.com>
To: Kaushik Phatak <Kaushik.Phatak@kpitcummins.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFC] New GDB Port CR16
Date: Mon, 27 Aug 2012 16:21:00 -0000 [thread overview]
Message-ID: <503B9E59.6050502@codesourcery.com> (raw)
In-Reply-To: <C6CA53A2A46BA7469348BDBD663AB65845B27868@KCHJEXMB03.kpit.com>
Kaushik,
Thanks for the patch. I didn't read your patch in details yet, but have
some comments on patch submission at first.
On 08/27/2012 02:36 PM, Kaushik Phatak wrote:
> 2012-08-24 Kaushik Phatak<kaushik.phatak@kpitcummins.com>
>
> gdb/ChangeLog:
> * configure.tgt (cr16-*-elf): New target.
> * cr16-tdep.c: New file.
>
> sim/cr16/ChangeLog:
> * interp.c (sim_complete_command): New stub function.
> * cr16_sim.h : Add defines for TRAP handling
> * simops.c: Breakpoint handling code
>
> opcodes/ChangeLog:
> * cr16-dis.c (match_opcode): Remove static function
> declaration.
> (make_instruction): Likewise.
>
Changes under opcodes dir should be submitted to binutils@sourceware.org.
> diff -upN gdb_src.orig/configure ./gdb_src/configure
> --- gdb_src.orig/configure 2012-06-28 17:20:52.000000000 +0530
> +++ ./gdb_src/configure 2012-08-17 16:56:10.000000000 +0530
> @@ -3447,7 +3447,7 @@ case "${target}" in
> noconfigdirs="$noconfigdirs target-libgloss gdb"
> ;;
> cr16-*-*)
> - noconfigdirs="$noconfigdirs gdb"
> + noconfigdirs="$noconfigdirs target-libgloss"
> ;;
> d10v-*-*)
> noconfigdirs="$noconfigdirs target-libgloss"
> diff -upN gdb_src.orig/configure.ac ./gdb_src/configure.ac
> --- gdb_src.orig/configure.ac 2012-06-28 17:20:52.000000000 +0530
> +++ ./gdb_src/configure.ac 2012-08-17 16:56:17.000000000 +0530
> @@ -873,7 +873,7 @@ case "${target}" in
> noconfigdirs="$noconfigdirs target-libgloss gdb"
> ;;
> cr16-*-*)
> - noconfigdirs="$noconfigdirs gdb"
> + noconfigdirs="$noconfigdirs target-libgloss"
> ;;
> d10v-*-*)
> noconfigdirs="$noconfigdirs target-libgloss"
The changes for top-level configure stuff should be submitted to
gcc-patches with changelog entry. Get it approved, apply it to gcc repo
once your gdb patch is approved, and finally merge this change from gcc
to binutils/gdb. This is what I did for adding new port tic6x last
year, IIRC.
--
Yao
next prev parent reply other threads:[~2012-08-27 16:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 6:37 Kaushik Phatak
2012-08-27 16:21 ` Yao Qi [this message]
2012-08-28 14:47 ` Kaushik Phatak
2012-08-29 22:14 ` Mike Frysinger
2012-08-30 5:23 ` Kaushik Phatak
2012-08-30 6:10 ` Mike Frysinger
2012-09-03 9:31 ` Pedro Alves
2012-09-04 3:52 ` Mike Frysinger
2012-09-04 6:50 ` Kaushik Phatak
2012-09-07 17:47 ` Pedro Alves
2012-09-11 13:16 ` Kaushik Phatak
2012-09-11 19:02 ` Mike Frysinger
2012-09-24 12:55 ` Kaushik Phatak
2012-09-11 19:00 ` Mike Frysinger
2012-08-27 21:10 ` Mike Frysinger
2012-08-28 16:24 ` Pedro Alves
2012-08-30 4:49 ` Kaushik Phatak
2012-08-30 5:14 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503B9E59.6050502@codesourcery.com \
--to=yao@codesourcery.com \
--cc=Kaushik.Phatak@kpitcummins.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox