From: Mike Frysinger <vapier@gentoo.org>
To: Kaushik Phatak <Kaushik.Phatak@kpitcummins.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Yao Qi <yao@codesourcery.com>, Pedro Alves <palves@redhat.com>
Subject: Re: [RFC] New GDB Port CR16
Date: Tue, 11 Sep 2012 19:02:00 -0000 [thread overview]
Message-ID: <CAJaTeTrxiEeCFrn0Le5FqMLz0tC_cCPRODYgczmoggs9SyqZEw@mail.gmail.com> (raw)
In-Reply-To: <C6CA53A2A46BA7469348BDBD663AB65845B2B47C@KCHJEXMB03.kpit.com>
On Tue, Sep 11, 2012 at 6:16 AM, Kaushik Phatak wrote:
> Mike, you had given the below feedback,
> http://sourceware.org/ml/gdb-patches/2012-08/msg00819.html
>> +int
>> match_opcode (void)
>> this new local prototype makes no sense. just delete it.
>
> When I remove these prototypes, it gives me a warning as follows,
> warning: no previous prototype for match_opcode
> Our build fails as it treats warnings as error. We can get around that by
> using "--disable-werror" I guess. But would this hunk be acceptable as is?
that means this file isn't including the header with the new
prototype. so the fix would be to change this file to include the
header.
-mike
next prev parent reply other threads:[~2012-09-11 19:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 6:37 Kaushik Phatak
2012-08-27 16:21 ` Yao Qi
2012-08-28 14:47 ` Kaushik Phatak
2012-08-29 22:14 ` Mike Frysinger
2012-08-30 5:23 ` Kaushik Phatak
2012-08-30 6:10 ` Mike Frysinger
2012-09-03 9:31 ` Pedro Alves
2012-09-04 3:52 ` Mike Frysinger
2012-09-04 6:50 ` Kaushik Phatak
2012-09-07 17:47 ` Pedro Alves
2012-09-11 13:16 ` Kaushik Phatak
2012-09-11 19:02 ` Mike Frysinger [this message]
2012-09-24 12:55 ` Kaushik Phatak
2012-09-11 19:00 ` Mike Frysinger
2012-08-27 21:10 ` Mike Frysinger
2012-08-28 16:24 ` Pedro Alves
2012-08-30 4:49 ` Kaushik Phatak
2012-08-30 5:14 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJaTeTrxiEeCFrn0Le5FqMLz0tC_cCPRODYgczmoggs9SyqZEw@mail.gmail.com \
--to=vapier@gentoo.org \
--cc=Kaushik.Phatak@kpitcummins.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox