From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2524 invoked by alias); 11 Sep 2012 19:02:49 -0000 Received: (qmail 2514 invoked by uid 22791); 11 Sep 2012 19:02:48 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Sep 2012 19:02:27 +0000 Received: by vbkv13 with SMTP id v13so1427080vbk.0 for ; Tue, 11 Sep 2012 12:02:27 -0700 (PDT) Received: by 10.58.247.165 with SMTP id yf5mr29015011vec.50.1347390147133; Tue, 11 Sep 2012 12:02:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.58.164.66 with HTTP; Tue, 11 Sep 2012 12:02:05 -0700 (PDT) In-Reply-To: References: <503B9E59.6050502@codesourcery.com> <504478D0.4040202@redhat.com> <504A331F.2090204@redhat.com> From: Mike Frysinger Date: Tue, 11 Sep 2012 19:02:00 -0000 Message-ID: Subject: Re: [RFC] New GDB Port CR16 To: Kaushik Phatak Cc: "gdb-patches@sourceware.org" , Yao Qi , Pedro Alves Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00174.txt.bz2 On Tue, Sep 11, 2012 at 6:16 AM, Kaushik Phatak wrote: > Mike, you had given the below feedback, > http://sourceware.org/ml/gdb-patches/2012-08/msg00819.html >> +int >> match_opcode (void) >> this new local prototype makes no sense. just delete it. > > When I remove these prototypes, it gives me a warning as follows, > warning: no previous prototype for match_opcode > Our build fails as it treats warnings as error. We can get around that by > using "--disable-werror" I guess. But would this hunk be acceptable as is? that means this file isn't including the header with the new prototype. so the fix would be to change this file to include the header. -mike