From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10124 invoked by alias); 27 Aug 2012 16:21:08 -0000 Received: (qmail 10111 invoked by uid 22791); 27 Aug 2012 16:21:04 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Aug 2012 16:20:51 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1T623W-0003DH-0V from Yao_Qi@mentor.com ; Mon, 27 Aug 2012 09:20:50 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 27 Aug 2012 09:20:48 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Mon, 27 Aug 2012 09:20:47 -0700 Message-ID: <503B9E59.6050502@codesourcery.com> Date: Mon, 27 Aug 2012 16:21:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Kaushik Phatak CC: "gdb-patches@sourceware.org" Subject: Re: [RFC] New GDB Port CR16 References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00803.txt.bz2 Kaushik, Thanks for the patch. I didn't read your patch in details yet, but have some comments on patch submission at first. On 08/27/2012 02:36 PM, Kaushik Phatak wrote: > 2012-08-24 Kaushik Phatak > > gdb/ChangeLog: > * configure.tgt (cr16-*-elf): New target. > * cr16-tdep.c: New file. > > sim/cr16/ChangeLog: > * interp.c (sim_complete_command): New stub function. > * cr16_sim.h : Add defines for TRAP handling > * simops.c: Breakpoint handling code > > opcodes/ChangeLog: > * cr16-dis.c (match_opcode): Remove static function > declaration. > (make_instruction): Likewise. > Changes under opcodes dir should be submitted to binutils@sourceware.org. > diff -upN gdb_src.orig/configure ./gdb_src/configure > --- gdb_src.orig/configure 2012-06-28 17:20:52.000000000 +0530 > +++ ./gdb_src/configure 2012-08-17 16:56:10.000000000 +0530 > @@ -3447,7 +3447,7 @@ case "${target}" in > noconfigdirs="$noconfigdirs target-libgloss gdb" > ;; > cr16-*-*) > - noconfigdirs="$noconfigdirs gdb" > + noconfigdirs="$noconfigdirs target-libgloss" > ;; > d10v-*-*) > noconfigdirs="$noconfigdirs target-libgloss" > diff -upN gdb_src.orig/configure.ac ./gdb_src/configure.ac > --- gdb_src.orig/configure.ac 2012-06-28 17:20:52.000000000 +0530 > +++ ./gdb_src/configure.ac 2012-08-17 16:56:17.000000000 +0530 > @@ -873,7 +873,7 @@ case "${target}" in > noconfigdirs="$noconfigdirs target-libgloss gdb" > ;; > cr16-*-*) > - noconfigdirs="$noconfigdirs gdb" > + noconfigdirs="$noconfigdirs target-libgloss" > ;; > d10v-*-*) > noconfigdirs="$noconfigdirs target-libgloss" The changes for top-level configure stuff should be submitted to gcc-patches with changelog entry. Get it approved, apply it to gcc repo once your gdb patch is approved, and finally merge this change from gcc to binutils/gdb. This is what I did for adding new port tic6x last year, IIRC. -- Yao