Re: [RFC] New GDB Port CR16

Mike Frysinger
2012-09-11T19:02:49Z

On Tue, Sep 11, 2012 at 6:16 AM, Kaushik Phatak wrote:
> Mike, you had given the below feedback,
> http://sourceware.org/ml/gdb-patches/2012-08/msg00819.html
>> +int
>> match_opcode (void)
>> this new local prototype makes no sense. just delete it.
>
> When I remove these prototypes, it gives me a warning as follows,
> warning: no previous prototype for match_opcode
> Our build fails as it treats warnings as error. We can get around that by
> using "--disable-werror" I guess. But would this hunk be acceptable as is?

that means this file isn't including the header with the new
prototype. so the fix would be to change this file to include the
header.
-mike