Re: [PATCH] gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS

[Pedro Alves <pedro@palves.net>]

On 2021-06-18 5:38 a.m., Mike Frysinger via Gdb-patches wrote:
> 
> how about at the top of acinclude.m4:
> dnl NB: When possible, try to avoid explicit includes of ../config/ files.
> dnl They're normally found by aclocal automatically and recorded in aclocal.m4.
> dnl However, some are kept here explicitly to silence harmless warnings from
> dnl aclocal when it finds AM_xxx macros via local search paths instead of
> dnl system search paths.
> -mike

That seems good to me, but I think better would be to put all such include lines
together and put the comment right on top of that section.  Like:

dnl NB: When possible, we try to avoid explicit includes of ../config/ files.
dnl They're normally found by aclocal automatically and recorded in aclocal.m4.
dnl However, the following are kept here explicitly to silence harmless warnings
dnl from aclocal when it finds AM_xxx macros via local search paths instead of
dnl system search paths.
m4_include([../config/foo.m4])
m4_include([../config/bar.m4])


I've had my share of "comments at the top" that I've missed in the past...