From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eJ1CORoB02A7eAAAWB0awg (envelope-from ) for ; Wed, 23 Jun 2021 05:38:34 -0400 Received: by simark.ca (Postfix, from userid 112) id E64131F1F2; Wed, 23 Jun 2021 05:38:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=MAILING_LIST_MULTI, RDNS_DYNAMIC autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8D2361E939 for ; Wed, 23 Jun 2021 05:38:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 36F7A3983009 for ; Wed, 23 Jun 2021 09:38:34 +0000 (GMT) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by sourceware.org (Postfix) with ESMTPS id 51D113850413 for ; Wed, 23 Jun 2021 09:38:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 51D113850413 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f52.google.com with SMTP id p10-20020a05600c430ab02901df57d735f7so3539061wme.3 for ; Wed, 23 Jun 2021 02:38:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=x5g0Tn/+EkyQRCfCDiaXv2r+h3K0ohChghg4XgOVQrk=; b=kfKvultFH3642nx7P8QTvHIB7Da5jaWHpcKnbEQWBYmHb31D2vTOXscb6PTIEXMc80 9ttihFeTopbHPpombC5TiOqa6P7ZyYC4vLoWEisJ3s81wu9YPuIAK7sd3uwdtBNWs/+E Y+p2Y7Qu7oWWQbcvTl6q+tQRnL56eVBso709c7RB03JSg3a0FspqUJrkpxAGXGQoSU/h pTAoflHO1N91xNJEpXqm1JjnZzxO9zQ/YjUPGQp2/7U9sQpwHtduJIZ6OWe9hSq/9g5X RwmnB84ZugVpNZ7inwGFTd5ezutpxgTXzpbAtWBrCR6K4U8kpuxTX2ZjMsX3YLVW5Pu8 KRIQ== X-Gm-Message-State: AOAM533g7PbkkJ3bgk95rpfPyOAc4tvgHkOaFoIoR+TgfqRyaI36mwcZ h2lnuuvPDMZZYvCc5VmTgcxkxERM7w7l/Q== X-Google-Smtp-Source: ABdhPJxP97/9jxCvxevRqbB9D5J1YOrCknhPVOifm2g0HsLM4wc2WGuxRu4TFdFkOgdoCx66UjzqUw== X-Received: by 2002:a05:600c:17d1:: with SMTP id y17mr9601200wmo.188.1624441101631; Wed, 23 Jun 2021 02:38:21 -0700 (PDT) Received: from ?IPv6:2001:8a0:f932:6a00:6b6e:c7b6:c5a7:aac3? ([2001:8a0:f932:6a00:6b6e:c7b6:c5a7:aac3]) by smtp.gmail.com with ESMTPSA id o26sm4827507wmr.29.2021.06.23.02.38.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jun 2021 02:38:20 -0700 (PDT) Subject: Re: [PATCH] gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS From: Pedro Alves To: Simon Marchi , gdb-patches@sourceware.org References: <20210615054416.1232-1-vapier@gentoo.org> <33565c24-0468-1ded-63db-d7ef402d5329@polymtl.ca> <5ece9821-45a3-14f6-33a1-3506b6efe72f@polymtl.ca> Message-ID: <4f273dab-3803-9143-7b16-4cb873834dd0@palves.net> Date: Wed, 23 Jun 2021 10:38:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-06-18 5:38 a.m., Mike Frysinger via Gdb-patches wrote: > > how about at the top of acinclude.m4: > dnl NB: When possible, try to avoid explicit includes of ../config/ files. > dnl They're normally found by aclocal automatically and recorded in aclocal.m4. > dnl However, some are kept here explicitly to silence harmless warnings from > dnl aclocal when it finds AM_xxx macros via local search paths instead of > dnl system search paths. > -mike That seems good to me, but I think better would be to put all such include lines together and put the comment right on top of that section. Like: dnl NB: When possible, we try to avoid explicit includes of ../config/ files. dnl They're normally found by aclocal automatically and recorded in aclocal.m4. dnl However, the following are kept here explicitly to silence harmless warnings dnl from aclocal when it finds AM_xxx macros via local search paths instead of dnl system search paths. m4_include([../config/foo.m4]) m4_include([../config/bar.m4]) I've had my share of "comments at the top" that I've missed in the past...