From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS
Date: Sat, 19 Jun 2021 22:17:01 -0400 [thread overview]
Message-ID: <bc6a24eb-822b-5114-6787-2510fe19f330@polymtl.ca> (raw)
In-Reply-To: <YM6jkKgmRtEFjl9d@vapier>
On 2021-06-19 10:10 p.m., Mike Frysinger wrote:
> On 19 Jun 2021 20:48, Simon Marchi wrote:
>> On 2021-06-18 10:03 a.m., Mike Frysinger via Gdb-patches wrote:
>>> These dirs don't use automake, so use AC_CONFIG_MACRO_DIRS to specify
>>> ../config as a search dir for m4 macros. This allows removal of a lot
>>> of hand-written m4_include's from acinclude.m4 files, and simplifies
>>> use of `aclocal` or `autoreconf` as manual -I is not needed.
>>> ---
>>> v2: include comment in top of acinclude.m4 files.
>>
>> With this patch, I get:
>>
>> configure.ac:531: warning: AC_LIB_PREPARE_PREFIX is m4_require'd but not m4_defun'd
>> ../config/iconv.m4:12: AM_ICONV_LINKFLAGS_BODY is expanded from...
>> ../config/iconv.m4:23: AM_ICONV_LINK is expanded from...
>> ../config/iconv.m4:104: AM_ICONV is expanded from...
>> configure.ac:531: the top level
>> configure.ac:531: warning: AC_LIB_RPATH is m4_require'd but not m4_defun'd
>> ../config/iconv.m4:12: AM_ICONV_LINKFLAGS_BODY is expanded from...
>> ../config/iconv.m4:23: AM_ICONV_LINK is expanded from...
>> ../config/iconv.m4:104: AM_ICONV is expanded from...
>> configure.ac:531: the top level
>>
>> To fix this, we'd need to keep these three lines:
>>
>> m4_include(../config/lib-ld.m4)
>> m4_include(../config/lib-prefix.m4)
>> m4_include(../config/lib-link.m4)
>>
>> If I bring them back, it's all clean.
>
> just in gdb/ right ?
Yes, gdbserver was fine.
> you're running `autoreconf` to test ?
> -mike
Yes, (autoreconf -vf).
Simon
next prev parent reply other threads:[~2021-06-20 2:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 1:24 [PATCH] gdb: add ../config/pkg.m4 in acinclude.m4 Simon Marchi via Gdb-patches
2021-05-09 20:00 ` Mike Frysinger via Gdb-patches
2021-05-10 0:16 ` Simon Marchi via Gdb-patches
2021-05-10 1:14 ` Mike Frysinger via Gdb-patches
2021-05-10 1:32 ` Simon Marchi via Gdb-patches
2021-05-10 13:25 ` Tom Tromey
2021-05-10 22:36 ` Mike Frysinger via Gdb-patches
2021-06-15 5:44 ` [PATCH] gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS Mike Frysinger via Gdb-patches
2021-06-17 2:30 ` Simon Marchi via Gdb-patches
2021-06-17 4:21 ` Mike Frysinger via Gdb-patches
2021-06-17 14:43 ` Simon Marchi via Gdb-patches
2021-06-18 4:38 ` Mike Frysinger via Gdb-patches
2021-06-18 13:22 ` Simon Marchi via Gdb-patches
2021-06-23 9:38 ` Pedro Alves
2021-06-23 22:26 ` Mike Frysinger via Gdb-patches
2021-06-24 18:45 ` Pedro Alves
2021-06-18 14:03 ` [PATCH v2] " Mike Frysinger via Gdb-patches
2021-06-20 0:48 ` Simon Marchi via Gdb-patches
2021-06-20 2:10 ` Mike Frysinger via Gdb-patches
2021-06-20 2:17 ` Simon Marchi via Gdb-patches [this message]
2021-06-20 2:22 ` [PATCH v3] " Mike Frysinger via Gdb-patches
2021-06-20 2:46 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc6a24eb-822b-5114-6787-2510fe19f330@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox