Re: [PATCH] gdb: add ../config/pkg.m4 in acinclude.m4

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-05-09 4:00 p.m., Mike Frysinger wrote:
> On 08 May 2021 21:24, Simon Marchi via Gdb-patches wrote:
>> Since commit adeab0c5b33f ("config/debuginfod: do not include pkg.m4
>> directly"), it no longer works to re-generate the autoconf stuff in GDB
>> without passing "-I ../config":
>>
>>     $ autoreconf -f
>>     configure.ac:161: error: possibly undefined macro: AC_MSG_ERROR
>>           If this token and others are legitimate, please use m4_pattern_allow.
>>           See the Autoconf documentation.
>>     configure.ac:329: error: possibly undefined macro: AC_MSG_WARN
>>     configure.ac:409: error: possibly undefined macro: AC_DEFINE
>>     autoreconf: /opt/autostuff/2.69/bin/autoconf failed with exit status: 1
>>
>> The reason is: since that commit, the PKG_CHECK_MODULES macro is not
>> found.  When passing "-I ../config" to the autoconf tools, then it's
>> found.  But if I understand correctly, the reason why we have all these
>> includes in acinclude.m4 is to avoid having to specify that, to make the
>> default invocation without special arguments "just work".
> 
> how about this instead ?  i can run `aclocal && autoconf` with this.
> 
> --- a/gdb/configure.ac
> +++ b/gdb/configure.ac
> @@ -18,9 +18,8 @@ dnl along with this program.  If not, see <http://www.gnu.org/licenses/>.
>  
>  dnl Process this file with autoconf to produce a configure script.
>  
> -m4_include(../config/debuginfod.m4)
> -
>  AC_INIT
> +AC_CONFIG_MACRO_DIRS([../config])
>  AC_CONFIG_SRCDIR([main.c])
>  AC_CONFIG_HEADERS(config.h:config.in, [echo > stamp-h])
>  AM_MAINTAINER_MODE
> -mike
> 

Ah yes, that sounds much better.  If we have this, could we remove all
lines in acinclude.m4 that refer to a file in ../config?