Re: [gdbadmin@sourceware.org: make-snapshot gdb current failed]

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-07-06 10:20 p.m., Joel Brobecker wrote:
> Hey Simon,
> 
> Please do not investigate if you can't see why your patch could be
> related to this, but I thought I'd ask you what you thought before
> I dive it myself (I've just had a very long day...).
> 
> I just got the attached report from our nightly source package script.
> Do you think your patch ...
> 
>     | commit 8043d65ba257c3f1ab08e2cce6a1b005923c17cb
>     | Author: Simon Marchi <simon.marchi@polymtl.ca>
>     | Date:   Tue Jul 6 14:54:29 2021 -0400
>     | Subject: gdb/testsuite: restore configure script
> 
> Might be the cause of it?
> 
> The log is not super helpful, but it looks like it's maybe failing
> during a "make distclean". Perhaps the key is this message?
> 
>     | Missing testsuite/Makefile
> 
> If it doesn't ring a bell, please feel free to let me isolate
> and reproduce the problem, so I can at least provide more details.
> Those nightly scripts are a real pain to follow, as they are
> multilayered and love to make things so generic as always being
> a pure headache in figuring out exactly what they do in practice...
> 

In the generated gdb/Makefile, I see:

    SUBDIRS = doc  testsuite data-directory testsuite

So what likely happens is that it tries to run distclean twice in
testsuite.  The second time around, the Makefile in there doesn't exist.

In Makefile.in, it looks like this:

    SUBDIRS = doc @subdirs@ data-directory testsuite

So the first testsuite comes from the AC_CONFIG_SUBDIRS macro in
configure.ac, and the second is hardcoded.  The second one should be
removed.  I missed it because it was not added by the patch that removed
testsuite/configure, it was added later.

I'll write / test / send a patch tomorrow.

Simon