From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>
Subject: Re: [gdbadmin@sourceware.org: make-snapshot gdb current failed]
Date: Wed, 7 Jul 2021 10:58:14 -0700 [thread overview]
Message-ID: <20210707175814.GF12614@adacore.com> (raw)
In-Reply-To: <4a63f76d-4882-a45b-25f3-fb201ff1366f@polymtl.ca>
> In the generated gdb/Makefile, I see:
>
> SUBDIRS = doc testsuite data-directory testsuite
>
> So what likely happens is that it tries to run distclean twice in
> testsuite. The second time around, the Makefile in there doesn't exist.
>
> In Makefile.in, it looks like this:
>
> SUBDIRS = doc @subdirs@ data-directory testsuite
>
> So the first testsuite comes from the AC_CONFIG_SUBDIRS macro in
> configure.ac, and the second is hardcoded. The second one should be
> removed. I missed it because it was not added by the patch that removed
> testsuite/configure, it was added later.
>
> I'll write / test / send a patch tomorrow.
Nice find. Thanks Simon.
--
Joel
next prev parent reply other threads:[~2021-07-07 17:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 2:20 Joel Brobecker
2021-07-07 3:04 ` Simon Marchi via Gdb-patches
2021-07-07 13:20 ` [PATCH master + 11] gdb/Makefile.in: remove testsuite from SUBDIRS Simon Marchi via Gdb-patches
2021-07-07 17:58 ` Joel Brobecker [this message]
2021-07-08 14:02 ` [gdbadmin@sourceware.org: make-snapshot gdb current failed] Simon Marchi via Gdb-patches
2021-07-08 15:10 ` Joel Brobecker
-- strict thread matches above, loose matches on Subject: below --
2021-01-11 2:53 Joel Brobecker
2021-01-11 2:59 ` H.J. Lu via Gdb-patches
2021-01-11 3:07 ` Joel Brobecker
2011-07-14 4:50 Joel Brobecker
2011-07-14 14:59 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210707175814.GF12614@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox