From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [gdbadmin@sourceware.org: make-snapshot gdb current failed]
Date: Thu, 8 Jul 2021 10:02:08 -0400 [thread overview]
Message-ID: <fb652488-5aa2-66f3-1418-910477f041a3@polymtl.ca> (raw)
In-Reply-To: <20210707175814.GF12614@adacore.com>
On 2021-07-07 1:58 p.m., Joel Brobecker wrote:
>> In the generated gdb/Makefile, I see:
>>
>> SUBDIRS = doc testsuite data-directory testsuite
>>
>> So what likely happens is that it tries to run distclean twice in
>> testsuite. The second time around, the Makefile in there doesn't exist.
>>
>> In Makefile.in, it looks like this:
>>
>> SUBDIRS = doc @subdirs@ data-directory testsuite
>>
>> So the first testsuite comes from the AC_CONFIG_SUBDIRS macro in
>> configure.ac, and the second is hardcoded. The second one should be
>> removed. I missed it because it was not added by the patch that removed
>> testsuite/configure, it was added later.
>>
>> I'll write / test / send a patch tomorrow.
>
> Nice find. Thanks Simon.
>
Thanks, I took that as an approval, so I pushed the patch to master and
gdb-11-branch (with ChangeLog entry).
Simon
next prev parent reply other threads:[~2021-07-08 14:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 2:20 Joel Brobecker
2021-07-07 3:04 ` Simon Marchi via Gdb-patches
2021-07-07 13:20 ` [PATCH master + 11] gdb/Makefile.in: remove testsuite from SUBDIRS Simon Marchi via Gdb-patches
2021-07-07 17:58 ` [gdbadmin@sourceware.org: make-snapshot gdb current failed] Joel Brobecker
2021-07-08 14:02 ` Simon Marchi via Gdb-patches [this message]
2021-07-08 15:10 ` Joel Brobecker
-- strict thread matches above, loose matches on Subject: below --
2021-01-11 2:53 Joel Brobecker
2021-01-11 2:59 ` H.J. Lu via Gdb-patches
2021-01-11 3:07 ` Joel Brobecker
2011-07-14 4:50 Joel Brobecker
2011-07-14 14:59 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb652488-5aa2-66f3-1418-910477f041a3@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=brobecker@adacore.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox