From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3zwNBukZ5WAkVAAAWB0awg (envelope-from ) for ; Tue, 06 Jul 2021 23:05:13 -0400 Received: by simark.ca (Postfix, from userid 112) id 0A47F1F1F4; Tue, 6 Jul 2021 23:05:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 558161E01F for ; Tue, 6 Jul 2021 23:05:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D68D03858002 for ; Wed, 7 Jul 2021 03:05:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D68D03858002 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625627111; bh=exyNRf0Qskcett/0MpYZp5pId78sAXm9JUUlztAxyeU=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ySh5eh0PFwdfvbnNyoZT4fp9wqos6sNp1LAGkkMYkMvt2VMWzwvNSHcAByTsqgTks XuOOFzawZFg10ALZLbfAdFDpMbepJyCb93qflvnOVxGwaAy6XA1PmIG9vF173bN/Ft cuFtbGGwnHYPQU21XcXEwmRSQOTujl1u7sEHbC9k= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1A9253858002 for ; Wed, 7 Jul 2021 03:04:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1A9253858002 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 16734jYI007781 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 6 Jul 2021 23:04:50 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 16734jYI007781 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B3FA01E01F; Tue, 6 Jul 2021 23:04:45 -0400 (EDT) Subject: Re: [gdbadmin@sourceware.org: make-snapshot gdb current failed] To: Joel Brobecker References: <20210707022057.GE12614@adacore.com> Message-ID: <4a63f76d-4882-a45b-25f3-fb201ff1366f@polymtl.ca> Date: Tue, 6 Jul 2021 23:04:45 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210707022057.GE12614@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 7 Jul 2021 03:04:45 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-07-06 10:20 p.m., Joel Brobecker wrote: > Hey Simon, > > Please do not investigate if you can't see why your patch could be > related to this, but I thought I'd ask you what you thought before > I dive it myself (I've just had a very long day...). > > I just got the attached report from our nightly source package script. > Do you think your patch ... > > | commit 8043d65ba257c3f1ab08e2cce6a1b005923c17cb > | Author: Simon Marchi > | Date: Tue Jul 6 14:54:29 2021 -0400 > | Subject: gdb/testsuite: restore configure script > > Might be the cause of it? > > The log is not super helpful, but it looks like it's maybe failing > during a "make distclean". Perhaps the key is this message? > > | Missing testsuite/Makefile > > If it doesn't ring a bell, please feel free to let me isolate > and reproduce the problem, so I can at least provide more details. > Those nightly scripts are a real pain to follow, as they are > multilayered and love to make things so generic as always being > a pure headache in figuring out exactly what they do in practice... > In the generated gdb/Makefile, I see: SUBDIRS = doc testsuite data-directory testsuite So what likely happens is that it tries to run distclean twice in testsuite. The second time around, the Makefile in there doesn't exist. In Makefile.in, it looks like this: SUBDIRS = doc @subdirs@ data-directory testsuite So the first testsuite comes from the AC_CONFIG_SUBDIRS macro in configure.ac, and the second is hardcoded. The second one should be removed. I missed it because it was not added by the patch that removed testsuite/configure, it was added later. I'll write / test / send a patch tomorrow. Simon