Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 0/3] Make global symbol objfile search order arch-dependent
Date: Fri, 01 Jun 2012 18:06:00 -0000	[thread overview]
Message-ID: <4FC8F092.9010507@redhat.com> (raw)
In-Reply-To: <1338496603-5423-1-git-send-email-brobecker@adacore.com>

On 05/31/2012 09:36 PM, Joel Brobecker wrote:

> Re: http://www.sourceware.org/ml/gdb-patches/2012-05/msg01026.html
> 
> This patch re-implement objfile searching order to make it gdbarch-
> dependent.  There are three patches to this series:
> 
>   #1: Reverts my first patch, in order to start from a clean slate.
>   #2: Introduces the new gdbarch method, and modifies the relevant
>       code to use it, instead of using ALL_OBJFILES.  The gdbarch's
>       default implemention, which is equivalent to ALL_OBJFILES,
>       is still used for all platforms, so there should be no functional
>       change on any platform, yet.
>   #3: Introduces a windows-specific version of that new gdbarch
>       method, and installs it for x86 and amd64 windows targets.


FWIW, I've read through them, and they look fine to me.

> The patch series has been tested on x86_64-linux, as well as on
> x86-windows, but using AdaCore's testsuite.  No regression observed.


-- 
Pedro Alves


      parent reply	other threads:[~2012-06-01 18:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-31 20:37 Joel Brobecker
2012-05-31 20:37 ` [RFA/commit 1/3] Revert "Search global symbols from the expression's block objfile first." Joel Brobecker
2012-05-31 20:37 ` [RFA 2/3] New "iterate_over_objfiles_in_search_order" gdbarch method Joel Brobecker
2012-05-31 20:37 ` [RFA 3/3] Windows-specific iterate_over_objfiles_in_search_order Joel Brobecker
2012-06-02 13:57   ` Jan Kratochvil
2012-06-02 15:32     ` Joel Brobecker
2012-06-02 15:49       ` Jan Kratochvil
2012-06-04  4:55   ` Doug Evans
2012-06-04 13:02     ` Joel Brobecker
2012-06-01 18:06 ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC8F092.9010507@redhat.com \
    --to=palves@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox