Re: [RFA 3/3] Windows-specific iterate_over_objfiles_in_search_order

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Thu, 31 May 2012 22:36:43 +0200, Joel Brobecker wrote:
>         * amd64-windows-tdep.c (amd64_windows_init_abi): Set
>         iterate_over_objfiles_in_search_order gdbarch method to
>         windows_iterate_over_objfiles_in_search_order.

On Fedora 17 x86_64 with --enable-targets=all I need the patch below.

amd64-windows-tdep.c: In function ‘amd64_windows_init_abi’:
amd64-windows-tdep.c:178:15: error: ‘windows_iterate_over_objfiles_in_search_order’ undeclared (first use in this function)
amd64-windows-tdep.c:178:15: note: each undeclared identifier is reported only once for each function it appears in

I would also prefer to use there in all the definitions/declarations:
typedef int 
  (iterate_over_objfiles_in_search_order_cb_ftype) (struct objfile *objfile, 
                                                    void *cb_data);
(feel free to shorten the name)

It does fix the gdb.fortran/library-module.exp regression here:
-FAIL: gdb.fortran/library-module.exp: print var_i in lib
+PASS: gdb.fortran/library-module.exp: print var_i in lib
-FAIL: gdb.fortran/library-module.exp: print var_i in main
+PASS: gdb.fortran/library-module.exp: print var_i in main

But on Fedora 17 (all x86* archs) it regresses these new testcase, they should
apparently be also made target specific:

-PASS: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from partial symtab
-PASS: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from symtab
+FAIL: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from partial symtab
+FAIL: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from symtab
-PASS: gdb.base/print-file-var.exp: print 'print-file-var-lib2.c'::this_version_id
+FAIL: gdb.base/print-file-var.exp: print 'print-file-var-lib2.c'::this_version_id

 print this_version_num^M
-$3 = 203^M
-(gdb) PASS: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from partial symtab
+$3 = 104^M
+(gdb) FAIL: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from partial symtab
 print this_version_num^M
-$4 = 203^M
-(gdb) PASS: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from symtab
+$4 = 104^M
+(gdb) FAIL: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from symtab
 print 'print-file-var-lib2.c'::this_version_id^M
-$2 = 203^M
-(gdb) PASS: gdb.base/print-file-var.exp: print 'print-file-var-lib2.c'::this_version_id
+$2 = 104^M
+(gdb) FAIL: gdb.base/print-file-var.exp: print 'print-file-var-lib2.c'::this_version_id


Thanks,
Jan


gdb/
2012-06-02  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* amd64-windows-tdep.c: Include windows-tdep.h.

diff --git a/gdb/amd64-windows-tdep.c b/gdb/amd64-windows-tdep.c
index f375409..41e0efa 100644
--- a/gdb/amd64-windows-tdep.c
+++ b/gdb/amd64-windows-tdep.c
@@ -23,6 +23,7 @@
 #include "gdbtypes.h"
 #include "gdbcore.h"
 #include "regcache.h"
+#include "windows-tdep.h"
 
 /* The registers used to pass integer arguments during a function call.  */
 static int amd64_windows_dummy_call_integer_regs[] =