From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26439 invoked by alias); 2 Jun 2012 13:57:38 -0000 Received: (qmail 26431 invoked by uid 22791); 2 Jun 2012 13:57:37 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 02 Jun 2012 13:57:15 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q52DuqfV030402 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 2 Jun 2012 09:56:52 -0400 Received: from host2.jankratochvil.net (ovpn-116-47.ams2.redhat.com [10.36.116.47]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q52DulfB001754 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sat, 2 Jun 2012 09:56:50 -0400 Date: Sat, 02 Jun 2012 13:57:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA 3/3] Windows-specific iterate_over_objfiles_in_search_order Message-ID: <20120602135647.GA18163@host2.jankratochvil.net> References: <1338496603-5423-1-git-send-email-brobecker@adacore.com> <1338496603-5423-4-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Disposition: inline In-Reply-To: <1338496603-5423-4-git-send-email-brobecker@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00051.txt.bz2 On Thu, 31 May 2012 22:36:43 +0200, Joel Brobecker wrote: > * amd64-windows-tdep.c (amd64_windows_init_abi): Set > iterate_over_objfiles_in_search_order gdbarch method to > windows_iterate_over_objfiles_in_search_order. On Fedora 17 x86_64 with --enable-targets=all I need the patch below. amd64-windows-tdep.c: In function ‘amd64_windows_init_abi’: amd64-windows-tdep.c:178:15: error: ‘windows_iterate_over_objfiles_in_search_order’ undeclared (first use in this function) amd64-windows-tdep.c:178:15: note: each undeclared identifier is reported only once for each function it appears in I would also prefer to use there in all the definitions/declarations: typedef int (iterate_over_objfiles_in_search_order_cb_ftype) (struct objfile *objfile, void *cb_data); (feel free to shorten the name) It does fix the gdb.fortran/library-module.exp regression here: -FAIL: gdb.fortran/library-module.exp: print var_i in lib +PASS: gdb.fortran/library-module.exp: print var_i in lib -FAIL: gdb.fortran/library-module.exp: print var_i in main +PASS: gdb.fortran/library-module.exp: print var_i in main But on Fedora 17 (all x86* archs) it regresses these new testcase, they should apparently be also made target specific: -PASS: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from partial symtab -PASS: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from symtab +FAIL: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from partial symtab +FAIL: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from symtab -PASS: gdb.base/print-file-var.exp: print 'print-file-var-lib2.c'::this_version_id +FAIL: gdb.base/print-file-var.exp: print 'print-file-var-lib2.c'::this_version_id print this_version_num^M -$3 = 203^M -(gdb) PASS: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from partial symtab +$3 = 104^M +(gdb) FAIL: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from partial symtab print this_version_num^M -$4 = 203^M -(gdb) PASS: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from symtab +$4 = 104^M +(gdb) FAIL: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from symtab print 'print-file-var-lib2.c'::this_version_id^M -$2 = 203^M -(gdb) PASS: gdb.base/print-file-var.exp: print 'print-file-var-lib2.c'::this_version_id +$2 = 104^M +(gdb) FAIL: gdb.base/print-file-var.exp: print 'print-file-var-lib2.c'::this_version_id Thanks, Jan gdb/ 2012-06-02 Jan Kratochvil * amd64-windows-tdep.c: Include windows-tdep.h. diff --git a/gdb/amd64-windows-tdep.c b/gdb/amd64-windows-tdep.c index f375409..41e0efa 100644 --- a/gdb/amd64-windows-tdep.c +++ b/gdb/amd64-windows-tdep.c @@ -23,6 +23,7 @@ #include "gdbtypes.h" #include "gdbcore.h" #include "regcache.h" +#include "windows-tdep.h" /* The registers used to pass integer arguments during a function call. */ static int amd64_windows_dummy_call_integer_regs[] =