From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7526 invoked by alias); 1 Jun 2012 18:06:04 -0000 Received: (qmail 7457 invoked by uid 22791); 1 Jun 2012 18:06:03 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Jun 2012 18:05:50 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q51I4tsK008439 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 1 Jun 2012 14:05:28 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q51GeoO2027593; Fri, 1 Jun 2012 12:40:51 -0400 Message-ID: <4FC8F092.9010507@redhat.com> Date: Fri, 01 Jun 2012 18:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [RFA 0/3] Make global symbol objfile search order arch-dependent References: <1338496603-5423-1-git-send-email-brobecker@adacore.com> In-Reply-To: <1338496603-5423-1-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00028.txt.bz2 On 05/31/2012 09:36 PM, Joel Brobecker wrote: > Re: http://www.sourceware.org/ml/gdb-patches/2012-05/msg01026.html > > This patch re-implement objfile searching order to make it gdbarch- > dependent. There are three patches to this series: > > #1: Reverts my first patch, in order to start from a clean slate. > #2: Introduces the new gdbarch method, and modifies the relevant > code to use it, instead of using ALL_OBJFILES. The gdbarch's > default implemention, which is equivalent to ALL_OBJFILES, > is still used for all platforms, so there should be no functional > change on any platform, yet. > #3: Introduces a windows-specific version of that new gdbarch > method, and installs it for x86 and amd64 windows targets. FWIW, I've read through them, and they look fine to me. > The patch series has been tested on x86_64-linux, as well as on > x86-windows, but using AdaCore's testsuite. No regression observed. -- Pedro Alves