From: Stan Shebs <stanshebs@earthlink.net>
To: gdb-patches@sourceware.org
Subject: Re: [RFC] init_breakpoint_sal: Add quotes around part of command in error message
Date: Tue, 15 May 2012 16:49:00 -0000 [thread overview]
Message-ID: <4FB2890B.9060105@earthlink.net> (raw)
In-Reply-To: <1337093982-27099-1-git-send-email-brobecker@adacore.com>
On 5/15/12 7:59 AM, Joel Brobecker wrote:
> gdb/ChangeLog:
>
> * breakpoint.c (init_breakpoint_sal): Add quotes around part
> of command in two error message.
>
> Untested for now, just trying to get feedback. Will definitely test
> before checking in, if people like the change.
>
I think the quoting is a good general principle to follow whenever
reporting any string that originates from user input, or from the
target; cut-n-paste errors and twitchy mice can conspire to generate
thoroughly confusing errors if the strings are not delimited somehow. I
could go with either double quotes or single quotes, but as Jan points
out, the general style seems to prefer a pair of single quotes.
Stan
prev parent reply other threads:[~2012-05-15 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 15:00 Joel Brobecker
2012-05-15 16:24 ` Tom Tromey
2012-05-15 16:28 ` Jan Kratochvil
2012-05-15 16:38 ` Joel Brobecker
2012-05-15 16:45 ` [commit] " Joel Brobecker
2012-05-15 16:49 ` Stan Shebs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB2890B.9060105@earthlink.net \
--to=stanshebs@earthlink.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox