From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: [RFC] init_breakpoint_sal: Add quotes around part of command in error message
Date: Tue, 15 May 2012 15:00:00 -0000 [thread overview]
Message-ID: <1337093982-27099-1-git-send-email-brobecker@adacore.com> (raw)
Hello,
What do you guys think of the following change. If changes:
(gdb) b *rendez_vous'address TASK 2
Garbage TASK 2 at end of command
... into ...
(gdb) b *rendez_vous'address TASK 2
Garbage `TASK 2' at end of command
(actually, the current output is `Garbage 2 at end of command', but
that's a bug that I am planning on fixing).
Surprisingly, this doesn't appear to be tested at all, at the moment,
as a quick grep for `Garbage' in all of gdb/testsuite did not yield
any match. I will submit a testcase with my fix that will test this.
gdb/ChangeLog:
* breakpoint.c (init_breakpoint_sal): Add quotes around part
of command in two error message.
Untested for now, just trying to get feedback. Will definitely test
before checking in, if people like the change.
Thanks,
--
Joel
---
gdb/breakpoint.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 9eecdf8..9557430 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -8629,7 +8629,7 @@ init_breakpoint_sal (struct breakpoint *b, struct gdbarch *gdbarch,
char *arg = b->cond_string;
loc->cond = parse_exp_1 (&arg, block_for_pc (loc->address), 0);
if (*arg)
- error (_("Garbage %s follows condition"), arg);
+ error (_("Garbage `%s' follows condition"), arg);
}
/* Dynamic printf requires and uses additional arguments on the
@@ -8642,7 +8642,7 @@ init_breakpoint_sal (struct breakpoint *b, struct gdbarch *gdbarch,
error (_("Format string required"));
}
else if (b->extra_string)
- error (_("Garbage %s at end of command"), b->extra_string);
+ error (_("Garbage `%s' at end of command"), b->extra_string);
}
b->display_canonical = display_canonical;
--
1.7.1
next reply other threads:[~2012-05-15 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 15:00 Joel Brobecker [this message]
2012-05-15 16:24 ` Tom Tromey
2012-05-15 16:28 ` Jan Kratochvil
2012-05-15 16:38 ` Joel Brobecker
2012-05-15 16:45 ` [commit] " Joel Brobecker
2012-05-15 16:49 ` [RFC] " Stan Shebs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337093982-27099-1-git-send-email-brobecker@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox