Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: [commit] init_breakpoint_sal: Add quotes around part of command in error message
Date: Tue, 15 May 2012 16:45:00 -0000	[thread overview]
Message-ID: <1337100321-32279-1-git-send-email-brobecker@adacore.com> (raw)
In-Reply-To: <20120515163748.GS10253@adacore.com>

For the record, this is the version I ended up checking in.

gdb/ChangeLog:

        * breakpoint.c (init_breakpoint_sal): Add quotes around part
        of command in two error message.

Tested on x86_64-linux.

---
 gdb/ChangeLog    |    5 +++++
 gdb/breakpoint.c |    4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c488a2f..2af1f59 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2012-05-15  Joel Brobecker  <brobecker@adacore.com>
 
+	* breakpoint.c (init_breakpoint_sal): Add quotes around part
+	of command in two error message.
+
+2012-05-15  Joel Brobecker  <brobecker@adacore.com>
+
 	* breakpoint.c (init_breakpoint_sal): Remove trailing spaces.
 
 2012-05-15  Joel Brobecker  <brobecker@adacore.com>
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 9eecdf8..1a76754 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -8629,7 +8629,7 @@ init_breakpoint_sal (struct breakpoint *b, struct gdbarch *gdbarch,
 	  char *arg = b->cond_string;
 	  loc->cond = parse_exp_1 (&arg, block_for_pc (loc->address), 0);
 	  if (*arg)
-              error (_("Garbage %s follows condition"), arg);
+              error (_("Garbage '%s' follows condition"), arg);
 	}
 
       /* Dynamic printf requires and uses additional arguments on the
@@ -8642,7 +8642,7 @@ init_breakpoint_sal (struct breakpoint *b, struct gdbarch *gdbarch,
 	    error (_("Format string required"));
 	}
       else if (b->extra_string)
-	error (_("Garbage %s at end of command"), b->extra_string);
+	error (_("Garbage '%s' at end of command"), b->extra_string);
     }
 
   b->display_canonical = display_canonical;
-- 
1.7.1


  reply	other threads:[~2012-05-15 16:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15 15:00 [RFC] " Joel Brobecker
2012-05-15 16:24 ` Tom Tromey
2012-05-15 16:28 ` Jan Kratochvil
2012-05-15 16:38   ` Joel Brobecker
2012-05-15 16:45     ` Joel Brobecker [this message]
2012-05-15 16:49 ` Stan Shebs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337100321-32279-1-git-send-email-brobecker@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox