From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19128 invoked by alias); 15 May 2012 16:49:43 -0000 Received: (qmail 19118 invoked by uid 22791); 15 May 2012 16:49:42 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from elasmtp-galgo.atl.sa.earthlink.net (HELO elasmtp-galgo.atl.sa.earthlink.net) (209.86.89.61) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 May 2012 16:49:16 +0000 Received: from [68.96.200.16] (helo=macbook2.local) by elasmtp-galgo.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1SUKw0-0000ow-5H for gdb-patches@sourceware.org; Tue, 15 May 2012 12:49:16 -0400 Message-ID: <4FB2890B.9060105@earthlink.net> Date: Tue, 15 May 2012 16:49:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [RFC] init_breakpoint_sal: Add quotes around part of command in error message References: <1337093982-27099-1-git-send-email-brobecker@adacore.com> In-Reply-To: <1337093982-27099-1-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da9406ddaee10f52bd0eab2d879ad4780b69d350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00583.txt.bz2 On 5/15/12 7:59 AM, Joel Brobecker wrote: > gdb/ChangeLog: > > * breakpoint.c (init_breakpoint_sal): Add quotes around part > of command in two error message. > > Untested for now, just trying to get feedback. Will definitely test > before checking in, if people like the change. > I think the quoting is a good general principle to follow whenever reporting any string that originates from user input, or from the target; cut-n-paste errors and twitchy mice can conspire to generate thoroughly confusing errors if the strings are not delimited somehow. I could go with either double quotes or single quotes, but as Jan points out, the general style seems to prefer a pair of single quotes. Stan