Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: Fix in-src-tree builds by making gdbserver/gnulib/ a separate library (a la libiberty, etc.), and adding ACX_CONFIGURE_DIR.
Date: Tue, 17 Apr 2012 10:49:00 -0000	[thread overview]
Message-ID: <4F8D45F4.7080809@redhat.com> (raw)
In-Reply-To: <4F8D450C.9070000@codesourcery.com>

On 04/17/2012 11:25 AM, Yao Qi wrote:

> On 04/17/2012 01:32 AM, Pedro Alves wrote:
>> diff --git c/gdb/acx_configure_dir.m4 w/gdb/acx_configure_dir.m4
>> new file mode 100644
>> index 0000000..822e882
>> --- /dev/null
>> +++ w/gdb/acx_configure_dir.m4
>> @@ -0,0 +1,104 @@
>> +# ACX_CONFIGURE_DIR(SRC-DIR-NAME, BUILD-DIR-NAME)
>> +# ---------------------------
>> +#
>> +# Configure a subdirectory.  This is an alternative to
>> +# AC_CONFIG_SUBDIRS that allows pointing the source directory
>> +# somewhere else.  The build directory is always a subdirectory of the
>> +# top build directory.  This is heavilly based on autoconf's
>> +# _AC_OUTPUT_SUBDIRS.
>> +#
>> +# Inputs:
>> +#   - SRC-DIR-NAME is the source directory, relative to $srcdir.
>> +#   - BUILD-DIR-NAME is `top-build -> build'
> 
> Do we need a copyright header here?


Thanks,  will add one.

>> diff --git c/gdb/defs.h w/gdb/defs.h
>> index 1075111..af66b00 100644
>> --- c/gdb/defs.h
>> +++ w/gdb/defs.h
>> @@ -26,6 +26,7 @@
>>  #  error gdbserver should not include gdb/defs.h
>>  #endif
>>
>> +#include "build-gnulib/../config.h"
> 
> It should be "build-gnulib/config.h".  I noticed you've fixed it in your
> git tree, so it is not a problem.

Yep.  Silly mistake.  :-)

-- 
Pedro Alves


      reply	other threads:[~2012-04-17 10:29 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11  8:41 [PATCH] Link gnulib in gdbserver Yao Qi
2012-04-11 18:11 ` Pedro Alves
2012-04-12  8:14   ` Yao Qi
2012-04-12 20:26     ` Doug Evans
2012-04-13  0:47       ` Yao Qi
2012-04-13 11:20         ` Pedro Alves
2012-04-13 11:24           ` Pedro Alves
2012-04-13 12:01           ` Yao Qi
2012-04-13 13:23             ` Pedro Alves
2012-04-14  3:40 ` Jan Kratochvil
2012-04-14  3:52   ` Yao Qi
2012-04-15 19:42     ` [patch] Fix in-src-tree builds by gdbserver/gnulib/ copy [Re: [PATCH] Link gnulib in gdbserver.] Jan Kratochvil
2012-04-16  9:42       ` Yao Qi
2012-04-16 10:11         ` [patch#2] Fix in-src-tree builds by gdbserver/gnulib/ copy Jan Kratochvil
2012-04-16 10:51           ` Yao Qi
2012-04-16 11:32       ` [patch] Fix in-src-tree builds by gdbserver/gnulib/ copy [Re: [PATCH] Link gnulib in gdbserver.] Pedro Alves
2012-04-16 18:51         ` Fix in-src-tree builds by making gdbserver/gnulib/ a separate library (a la libiberty, etc.), and adding ACX_CONFIGURE_DIR Pedro Alves
2012-04-16 18:35           ` Jan Kratochvil
2012-04-17 16:55             ` Pedro Alves
2012-04-17 17:27               ` Jan Kratochvil
2012-04-17 18:55                 ` Pedro Alves
2012-04-17 23:52                   ` Joel Brobecker
2012-04-18  9:16                     ` Pedro Alves
2012-04-18  9:32                       ` Jan Kratochvil
2012-04-18 10:52                         ` Pedro Alves
2012-04-18 12:34                           ` Jan Kratochvil
2012-04-18 12:52                             ` Pedro Alves
2012-04-18 13:04                               ` Jan Kratochvil
2012-04-18 13:18                                 ` Pedro Alves
2012-04-18 15:52                                   ` Jan Kratochvil
2012-04-18 16:04                                     ` Pedro Alves
2012-04-18 16:09                                       ` Jan Kratochvil
2012-04-18 16:16                                         ` Pedro Alves
2012-04-18 16:09                                       ` Pedro Alves
2012-04-18 16:04                                     ` Mark Kettenis
2012-04-18 16:14                                       ` Jan Kratochvil
2012-04-18 17:05                                         ` Joel Brobecker
2012-04-18 15:04                           ` Joel Brobecker
2012-04-19 15:46                             ` gnulib/ -> gnulib/import/ Pedro Alves
2012-04-16 20:06           ` Fix in-src-tree builds by making gdbserver/gnulib/ a separate library (a la libiberty, etc.), and adding ACX_CONFIGURE_DIR Tom Tromey
2012-04-16 20:36             ` Doug Evans
2012-04-16 20:41               ` Pedro Alves
2012-04-16 22:57                 ` Joel Brobecker
2012-04-16 23:19                   ` Stan Shebs
2012-04-17 12:16                     ` Tom Tromey
2012-04-17 15:16                       ` Joel Brobecker
2012-04-17 10:29           ` Yao Qi
2012-04-17 10:49             ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8D45F4.7080809@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox