From: Yao Qi <yao@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Link gnulib in gdbserver.
Date: Fri, 13 Apr 2012 00:47:00 -0000 [thread overview]
Message-ID: <4F8774DC.4040004@codesourcery.com> (raw)
In-Reply-To: <CADPb22TaDkxZG2KPYXJ8_+FnX81OHrwffgf9Z7VusLGyA5rDOA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
On 04/13/2012 04:21 AM, Doug Evans wrote:
> Pedro thinks it's this:
> FLAGS_TO_PASS changes $srcdir. and install: does @$(MAKE)
> $(FLAGS_TO_PASS) install-only
$(FLAGS_TO_PASS) is used to pass to Makefiles in sub-dirs. When
invoking install-only target, it is unnecessary to pass
$(FLAGS_TO_PASS). In the commands of target install-only below,
$(FLAGS_TO_PASS) is passed to Makefiles in sub-dirs.
This patch just simply remove $(FLAGS_TO_PASS) in install target. Is it OK?
Tested by gdbserver instal/uninstall and gdb install. It looks right.
--
Yao (é½å°§)
[-- Attachment #2: 0009-Fix-an-install-failure.patch --]
[-- Type: text/x-patch, Size: 1316 bytes --]
gdb:
2012-04-13 Yao Qi <yao@codesourcery.com>
* Makefile.in (install): Don't pass $(FLAGS_TO_PASS) to make.
gdb/gdbserver:
2012-04-13 Yao Qi <yao@codesourcery.com>
* Makefile.in (install): Don't pass $(FLAGS_TO_PASS) to make.
---
gdb/Makefile.in | 2 +-
gdb/gdbserver/Makefile.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index b8b7109..4d80036 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1012,7 +1012,7 @@ gdb.z:gdb.1
# time it takes for make to check that all is up to date.
# install-only is intended to address that need.
install: all
- @$(MAKE) $(FLAGS_TO_PASS) install-only
+ @$(MAKE) install-only
install-only: $(CONFIG_INSTALL)
transformed_name=`t='$(program_transform_name)'; \
diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in
index aa8b13b..84c5834 100644
--- a/gdb/gdbserver/Makefile.in
+++ b/gdb/gdbserver/Makefile.in
@@ -214,7 +214,7 @@ all: gdbserver$(EXEEXT) gdbreplay$(EXEEXT) $(extra_libraries)
# time it takes for make to check that all is up to date.
# install-only is intended to address that need.
install: all
- @$(MAKE) $(FLAGS_TO_PASS) install-only
+ @$(MAKE) install-only
install-only:
n=`echo gdbserver | sed '$(program_transform_name)'`; \
--
1.7.0.4
next prev parent reply other threads:[~2012-04-13 0:36 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 8:41 Yao Qi
2012-04-11 18:11 ` Pedro Alves
2012-04-12 8:14 ` Yao Qi
2012-04-12 20:26 ` Doug Evans
2012-04-13 0:47 ` Yao Qi [this message]
2012-04-13 11:20 ` Pedro Alves
2012-04-13 11:24 ` Pedro Alves
2012-04-13 12:01 ` Yao Qi
2012-04-13 13:23 ` Pedro Alves
2012-04-14 3:40 ` Jan Kratochvil
2012-04-14 3:52 ` Yao Qi
2012-04-15 19:42 ` [patch] Fix in-src-tree builds by gdbserver/gnulib/ copy [Re: [PATCH] Link gnulib in gdbserver.] Jan Kratochvil
2012-04-16 9:42 ` Yao Qi
2012-04-16 10:11 ` [patch#2] Fix in-src-tree builds by gdbserver/gnulib/ copy Jan Kratochvil
2012-04-16 10:51 ` Yao Qi
2012-04-16 11:32 ` [patch] Fix in-src-tree builds by gdbserver/gnulib/ copy [Re: [PATCH] Link gnulib in gdbserver.] Pedro Alves
2012-04-16 18:51 ` Fix in-src-tree builds by making gdbserver/gnulib/ a separate library (a la libiberty, etc.), and adding ACX_CONFIGURE_DIR Pedro Alves
2012-04-16 18:35 ` Jan Kratochvil
2012-04-17 16:55 ` Pedro Alves
2012-04-17 17:27 ` Jan Kratochvil
2012-04-17 18:55 ` Pedro Alves
2012-04-17 23:52 ` Joel Brobecker
2012-04-18 9:16 ` Pedro Alves
2012-04-18 9:32 ` Jan Kratochvil
2012-04-18 10:52 ` Pedro Alves
2012-04-18 12:34 ` Jan Kratochvil
2012-04-18 12:52 ` Pedro Alves
2012-04-18 13:04 ` Jan Kratochvil
2012-04-18 13:18 ` Pedro Alves
2012-04-18 15:52 ` Jan Kratochvil
2012-04-18 16:04 ` Pedro Alves
2012-04-18 16:09 ` Jan Kratochvil
2012-04-18 16:16 ` Pedro Alves
2012-04-18 16:09 ` Pedro Alves
2012-04-18 16:04 ` Mark Kettenis
2012-04-18 16:14 ` Jan Kratochvil
2012-04-18 17:05 ` Joel Brobecker
2012-04-18 15:04 ` Joel Brobecker
2012-04-19 15:46 ` gnulib/ -> gnulib/import/ Pedro Alves
2012-04-16 20:06 ` Fix in-src-tree builds by making gdbserver/gnulib/ a separate library (a la libiberty, etc.), and adding ACX_CONFIGURE_DIR Tom Tromey
2012-04-16 20:36 ` Doug Evans
2012-04-16 20:41 ` Pedro Alves
2012-04-16 22:57 ` Joel Brobecker
2012-04-16 23:19 ` Stan Shebs
2012-04-17 12:16 ` Tom Tromey
2012-04-17 15:16 ` Joel Brobecker
2012-04-17 10:29 ` Yao Qi
2012-04-17 10:49 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8774DC.4040004@codesourcery.com \
--to=yao@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox