From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1333 invoked by alias); 13 Apr 2012 00:36:29 -0000 Received: (qmail 1150 invoked by uid 22791); 13 Apr 2012 00:36:28 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Apr 2012 00:36:01 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SIUUY-0007Am-V3 from Yao_Qi@mentor.com ; Thu, 12 Apr 2012 17:35:58 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 12 Apr 2012 17:35:36 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Thu, 12 Apr 2012 17:35:58 -0700 Message-ID: <4F8774DC.4040004@codesourcery.com> Date: Fri, 13 Apr 2012 00:47:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Doug Evans CC: Pedro Alves , Subject: Re: [PATCH] Link gnulib in gdbserver. References: <1334127046-27627-1-git-send-email-yao@codesourcery.com> <4F85C251.1070705@redhat.com> <4F867BA5.40201@codesourcery.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------010809000702060306050004" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00330.txt.bz2 --------------010809000702060306050004 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Content-length: 569 On 04/13/2012 04:21 AM, Doug Evans wrote: > Pedro thinks it's this: > FLAGS_TO_PASS changes $srcdir. and install: does @$(MAKE) > $(FLAGS_TO_PASS) install-only $(FLAGS_TO_PASS) is used to pass to Makefiles in sub-dirs. When invoking install-only target, it is unnecessary to pass $(FLAGS_TO_PASS). In the commands of target install-only below, $(FLAGS_TO_PASS) is passed to Makefiles in sub-dirs. This patch just simply remove $(FLAGS_TO_PASS) in install target. Is it OK? Tested by gdbserver instal/uninstall and gdb install. It looks right. -- Yao (齐尧) --------------010809000702060306050004 Content-Type: text/x-patch; name="0009-Fix-an-install-failure.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0009-Fix-an-install-failure.patch" Content-length: 1316 gdb: 2012-04-13 Yao Qi * Makefile.in (install): Don't pass $(FLAGS_TO_PASS) to make. gdb/gdbserver: 2012-04-13 Yao Qi * Makefile.in (install): Don't pass $(FLAGS_TO_PASS) to make. --- gdb/Makefile.in | 2 +- gdb/gdbserver/Makefile.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index b8b7109..4d80036 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -1012,7 +1012,7 @@ gdb.z:gdb.1 # time it takes for make to check that all is up to date. # install-only is intended to address that need. install: all - @$(MAKE) $(FLAGS_TO_PASS) install-only + @$(MAKE) install-only install-only: $(CONFIG_INSTALL) transformed_name=`t='$(program_transform_name)'; \ diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in index aa8b13b..84c5834 100644 --- a/gdb/gdbserver/Makefile.in +++ b/gdb/gdbserver/Makefile.in @@ -214,7 +214,7 @@ all: gdbserver$(EXEEXT) gdbreplay$(EXEEXT) $(extra_libraries) # time it takes for make to check that all is up to date. # install-only is intended to address that need. install: all - @$(MAKE) $(FLAGS_TO_PASS) install-only + @$(MAKE) install-only install-only: n=`echo gdbserver | sed '$(program_transform_name)'`; \ -- 1.7.0.4 --------------010809000702060306050004--