From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: Doug Evans <dje@google.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Link gnulib in gdbserver.
Date: Fri, 13 Apr 2012 12:01:00 -0000 [thread overview]
Message-ID: <4F881299.2010300@codesourcery.com> (raw)
In-Reply-To: <4F88088D.5030601@redhat.com>
On 04/13/2012 07:05 PM, Pedro Alves wrote:
> So I think this is better, and actually cleaner, for keeping FLAGS_TO_PASS
> as it was, the gnulib specifics closer to gnulib code, and actually adding a
> comment just around the gnulib specific GNULIB_FLAGS_TO_PASS. :-)
>
Agreed. All these flags are gnulib specific so far.
GNULIB_FLAGS_TO_PASS is cleaner.
> BTW, is it really necessary to VPATH set to:
>
> VPATH=$(abs_top_srcdir)/../gnulib:$(abs_top_srcdir)"
>
> instead of just:
>
> VPATH=$(abs_top_srcdir)/../gnulib"
>
> I tried it, and things still appear to build fine. IOW, is there a case
> where building gnulib would need to find something in the gdbserver source dir?
IIRC, I append "$(abs_top_srcdir)" in VPATH because gnulib finds file
`configure' for `config.status' in some dependency. Now, I remove it
from VPATH, but unable to get a build error, which means we can remove
$(abs_top_srcdir) from VPATH, and my memory is bad :)
Patch looks good to me. Thanks.
--
Yao (é½å°§)
next prev parent reply other threads:[~2012-04-13 11:49 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 8:41 Yao Qi
2012-04-11 18:11 ` Pedro Alves
2012-04-12 8:14 ` Yao Qi
2012-04-12 20:26 ` Doug Evans
2012-04-13 0:47 ` Yao Qi
2012-04-13 11:20 ` Pedro Alves
2012-04-13 11:24 ` Pedro Alves
2012-04-13 12:01 ` Yao Qi [this message]
2012-04-13 13:23 ` Pedro Alves
2012-04-14 3:40 ` Jan Kratochvil
2012-04-14 3:52 ` Yao Qi
2012-04-15 19:42 ` [patch] Fix in-src-tree builds by gdbserver/gnulib/ copy [Re: [PATCH] Link gnulib in gdbserver.] Jan Kratochvil
2012-04-16 9:42 ` Yao Qi
2012-04-16 10:11 ` [patch#2] Fix in-src-tree builds by gdbserver/gnulib/ copy Jan Kratochvil
2012-04-16 10:51 ` Yao Qi
2012-04-16 11:32 ` [patch] Fix in-src-tree builds by gdbserver/gnulib/ copy [Re: [PATCH] Link gnulib in gdbserver.] Pedro Alves
2012-04-16 18:51 ` Fix in-src-tree builds by making gdbserver/gnulib/ a separate library (a la libiberty, etc.), and adding ACX_CONFIGURE_DIR Pedro Alves
2012-04-16 18:35 ` Jan Kratochvil
2012-04-17 16:55 ` Pedro Alves
2012-04-17 17:27 ` Jan Kratochvil
2012-04-17 18:55 ` Pedro Alves
2012-04-17 23:52 ` Joel Brobecker
2012-04-18 9:16 ` Pedro Alves
2012-04-18 9:32 ` Jan Kratochvil
2012-04-18 10:52 ` Pedro Alves
2012-04-18 12:34 ` Jan Kratochvil
2012-04-18 12:52 ` Pedro Alves
2012-04-18 13:04 ` Jan Kratochvil
2012-04-18 13:18 ` Pedro Alves
2012-04-18 15:52 ` Jan Kratochvil
2012-04-18 16:04 ` Mark Kettenis
2012-04-18 16:14 ` Jan Kratochvil
2012-04-18 17:05 ` Joel Brobecker
2012-04-18 16:04 ` Pedro Alves
2012-04-18 16:09 ` Jan Kratochvil
2012-04-18 16:16 ` Pedro Alves
2012-04-18 16:09 ` Pedro Alves
2012-04-18 15:04 ` Joel Brobecker
2012-04-19 15:46 ` gnulib/ -> gnulib/import/ Pedro Alves
2012-04-16 20:06 ` Fix in-src-tree builds by making gdbserver/gnulib/ a separate library (a la libiberty, etc.), and adding ACX_CONFIGURE_DIR Tom Tromey
2012-04-16 20:36 ` Doug Evans
2012-04-16 20:41 ` Pedro Alves
2012-04-16 22:57 ` Joel Brobecker
2012-04-16 23:19 ` Stan Shebs
2012-04-17 12:16 ` Tom Tromey
2012-04-17 15:16 ` Joel Brobecker
2012-04-17 10:29 ` Yao Qi
2012-04-17 10:49 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F881299.2010300@codesourcery.com \
--to=yao@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox