From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5602 invoked by alias); 13 Apr 2012 11:49:22 -0000 Received: (qmail 5594 invoked by uid 22791); 13 Apr 2012 11:49:21 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Apr 2012 11:49:09 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SIezz-0004mf-WB from Yao_Qi@mentor.com ; Fri, 13 Apr 2012 04:49:08 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 13 Apr 2012 04:48:44 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Fri, 13 Apr 2012 04:49:07 -0700 Message-ID: <4F881299.2010300@codesourcery.com> Date: Fri, 13 Apr 2012 12:01:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Pedro Alves CC: Doug Evans , Subject: Re: [PATCH] Link gnulib in gdbserver. References: <1334127046-27627-1-git-send-email-yao@codesourcery.com> <4F85C251.1070705@redhat.com> <4F867BA5.40201@codesourcery.com> <4F8774DC.4040004@codesourcery.com> <4F88088D.5030601@redhat.com> In-Reply-To: <4F88088D.5030601@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00349.txt.bz2 On 04/13/2012 07:05 PM, Pedro Alves wrote: > So I think this is better, and actually cleaner, for keeping FLAGS_TO_PASS > as it was, the gnulib specifics closer to gnulib code, and actually adding a > comment just around the gnulib specific GNULIB_FLAGS_TO_PASS. :-) > Agreed. All these flags are gnulib specific so far. GNULIB_FLAGS_TO_PASS is cleaner. > BTW, is it really necessary to VPATH set to: > > VPATH=$(abs_top_srcdir)/../gnulib:$(abs_top_srcdir)" > > instead of just: > > VPATH=$(abs_top_srcdir)/../gnulib" > > I tried it, and things still appear to build fine. IOW, is there a case > where building gnulib would need to find something in the gdbserver source dir? IIRC, I append "$(abs_top_srcdir)" in VPATH because gnulib finds file `configure' for `config.status' in some dependency. Now, I remove it from VPATH, but unable to get a build error, which means we can remove $(abs_top_srcdir) from VPATH, and my memory is bad :) Patch looks good to me. Thanks. -- Yao (齐尧)