From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20647 invoked by alias); 17 Apr 2012 10:29:33 -0000 Received: (qmail 20639 invoked by uid 22791); 17 Apr 2012 10:29:32 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Apr 2012 10:29:15 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3HATAYb006141 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 17 Apr 2012 06:29:10 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3HAT9V2009657; Tue, 17 Apr 2012 06:29:09 -0400 Message-ID: <4F8D45F4.7080809@redhat.com> Date: Tue, 17 Apr 2012 10:49:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Yao Qi CC: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: Fix in-src-tree builds by making gdbserver/gnulib/ a separate library (a la libiberty, etc.), and adding ACX_CONFIGURE_DIR. References: <1334127046-27627-1-git-send-email-yao@codesourcery.com> <20120413212559.GA5867@host2.jankratochvil.net> <4F88F188.1050401@codesourcery.com> <20120415164917.GA2861@host2.jankratochvil.net> <4F8BFB25.5030808@redhat.com> <4F8C5794.5050302@redhat.com> <4F8D450C.9070000@codesourcery.com> In-Reply-To: <4F8D450C.9070000@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00454.txt.bz2 On 04/17/2012 11:25 AM, Yao Qi wrote: > On 04/17/2012 01:32 AM, Pedro Alves wrote: >> diff --git c/gdb/acx_configure_dir.m4 w/gdb/acx_configure_dir.m4 >> new file mode 100644 >> index 0000000..822e882 >> --- /dev/null >> +++ w/gdb/acx_configure_dir.m4 >> @@ -0,0 +1,104 @@ >> +# ACX_CONFIGURE_DIR(SRC-DIR-NAME, BUILD-DIR-NAME) >> +# --------------------------- >> +# >> +# Configure a subdirectory. This is an alternative to >> +# AC_CONFIG_SUBDIRS that allows pointing the source directory >> +# somewhere else. The build directory is always a subdirectory of the >> +# top build directory. This is heavilly based on autoconf's >> +# _AC_OUTPUT_SUBDIRS. >> +# >> +# Inputs: >> +# - SRC-DIR-NAME is the source directory, relative to $srcdir. >> +# - BUILD-DIR-NAME is `top-build -> build' > > Do we need a copyright header here? Thanks, will add one. >> diff --git c/gdb/defs.h w/gdb/defs.h >> index 1075111..af66b00 100644 >> --- c/gdb/defs.h >> +++ w/gdb/defs.h >> @@ -26,6 +26,7 @@ >> # error gdbserver should not include gdb/defs.h >> #endif >> >> +#include "build-gnulib/../config.h" > > It should be "build-gnulib/config.h". I noticed you've fixed it in your > git tree, so it is not a problem. Yep. Silly mistake. :-) -- Pedro Alves