* [ARI patch] Fix gawk-4.0 warning
@ 2012-03-14 20:15 Jan Kratochvil
2012-03-14 21:12 ` Joel Brobecker
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kratochvil @ 2012-03-14 20:15 UTC (permalink / raw)
To: gdb-patches
Hi,
unaware who maintains ARI:
For http://sourceware.org/gdb/current/ari/gdb_ari.sh
with gawk-4.0.0-4.fc17.x86_64 getting:
awk: cmd. line:135: warning: regexp component `[:digit:]' should probably be `[[:digit:]]'
Untested.
Thanks,
Jan
* gdb_ari.sh (GNU/Linux): Fix '[:digit:]' compatibility with gawk-4.0.
--- /home/jkratoch/t/gdb_ari.sh-orig 2012-03-14 20:15:48.804209849 +0100
+++ /home/jkratoch/t/gdb_ari.sh 2012-03-14 20:57:07.255866311 +0100
@@ -242,7 +242,7 @@ Do not use `Linux'\'', instead use `Linu
&& !/(^|[^_[:alnum:]])Linux\[sic\]([^_[:alnum:]]|$)/ \
&& !/(^|[^_[:alnum:]])GNU\/Linux([^_[:alnum:]]|$)/ \
&& !/(^|[^_[:alnum:]])Linux kernel([^_[:alnum:]]|$)/ \
-&& !/(^|[^_[:alnum:]])Linux [:digit:]\.[:digit:]+)/ {
+&& !/(^|[^_[:alnum:]])Linux [[:digit:]]\.[[:digit:]]+)/ {
fail("GNU/Linux")
}
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ARI patch] Fix gawk-4.0 warning
2012-03-14 20:15 [ARI patch] Fix gawk-4.0 warning Jan Kratochvil
@ 2012-03-14 21:12 ` Joel Brobecker
2012-03-15 10:19 ` Pedro Alves
0 siblings, 1 reply; 6+ messages in thread
From: Joel Brobecker @ 2012-03-14 21:12 UTC (permalink / raw)
To: Jan Kratochvil, muller; +Cc: gdb-patches
> unaware who maintains ARI:
Pierre Muller has been the most active contributor in that area.
I see him as the de-facto maintainer, or rather "authorized committer".
These files are not part of the GDB repository, so could be maintained
a little differently, or we could say they fall under the GMs umbrella,
or ask Pierre if he wants to be the maintainer....
>
> For http://sourceware.org/gdb/current/ari/gdb_ari.sh
> with gawk-4.0.0-4.fc17.x86_64 getting:
> awk: cmd. line:135: warning: regexp component `[:digit:]' should probably be `[[:digit:]]'
>
> Untested.
>
>
> Thanks,
> Jan
>
>
> * gdb_ari.sh (GNU/Linux): Fix '[:digit:]' compatibility with gawk-4.0.
>
> --- /home/jkratoch/t/gdb_ari.sh-orig 2012-03-14 20:15:48.804209849 +0100
> +++ /home/jkratoch/t/gdb_ari.sh 2012-03-14 20:57:07.255866311 +0100
> @@ -242,7 +242,7 @@ Do not use `Linux'\'', instead use `Linu
> && !/(^|[^_[:alnum:]])Linux\[sic\]([^_[:alnum:]]|$)/ \
> && !/(^|[^_[:alnum:]])GNU\/Linux([^_[:alnum:]]|$)/ \
> && !/(^|[^_[:alnum:]])Linux kernel([^_[:alnum:]]|$)/ \
> -&& !/(^|[^_[:alnum:]])Linux [:digit:]\.[:digit:]+)/ {
> +&& !/(^|[^_[:alnum:]])Linux [[:digit:]]\.[[:digit:]]+)/ {
> fail("GNU/Linux")
> }
>
--
Joel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ARI patch] Fix gawk-4.0 warning
2012-03-14 21:12 ` Joel Brobecker
@ 2012-03-15 10:19 ` Pedro Alves
2012-03-15 15:25 ` Joel Brobecker
0 siblings, 1 reply; 6+ messages in thread
From: Pedro Alves @ 2012-03-15 10:19 UTC (permalink / raw)
To: Joel Brobecker; +Cc: Jan Kratochvil, muller, gdb-patches
On 03/14/2012 09:11 PM, Joel Brobecker wrote:
>> unaware who maintains ARI:
>
> Pierre Muller has been the most active contributor in that area.
> I see him as the de-facto maintainer, or rather "authorized committer".
> These files are not part of the GDB repository, so could be maintained
> a little differently, or we could say they fall under the GMs umbrella,
> or ask Pierre if he wants to be the maintainer....
I thought he already was the maintainer? Did we forget to send an announcement
when it happened? I can't find it...
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ARI patch] Fix gawk-4.0 warning
2012-03-15 10:19 ` Pedro Alves
@ 2012-03-15 15:25 ` Joel Brobecker
2012-03-15 15:52 ` Pedro Alves
0 siblings, 1 reply; 6+ messages in thread
From: Joel Brobecker @ 2012-03-15 15:25 UTC (permalink / raw)
To: Pedro Alves; +Cc: Jan Kratochvil, muller, gdb-patches
> > Pierre Muller has been the most active contributor in that area.
> > I see him as the de-facto maintainer, or rather "authorized committer".
> > These files are not part of the GDB repository, so could be maintained
> > a little differently, or we could say they fall under the GMs umbrella,
> > or ask Pierre if he wants to be the maintainer....
>
> I thought he already was the maintainer? Did we forget to send an
> announcement when it happened? I can't find it...
That's a good correction. He is, in fact, the Maintainer, since
the end of March 2009. It probably flew under the radar because
the script isn't in the same repo as GDB, I am not sure anymore.
We should document this: Howzabout we start a MAINTAINERS file in
the "ss" repo as well?
--
Joel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ARI patch] Fix gawk-4.0 warning
2012-03-15 15:25 ` Joel Brobecker
@ 2012-03-15 15:52 ` Pedro Alves
2012-03-15 16:21 ` Joel Brobecker
0 siblings, 1 reply; 6+ messages in thread
From: Pedro Alves @ 2012-03-15 15:52 UTC (permalink / raw)
To: Joel Brobecker; +Cc: Pedro Alves, Jan Kratochvil, muller, gdb-patches
On 03/15/2012 03:24 PM, Joel Brobecker wrote:
>>> Pierre Muller has been the most active contributor in that area.
>>> I see him as the de-facto maintainer, or rather "authorized committer".
>>> These files are not part of the GDB repository, so could be maintained
>>> a little differently, or we could say they fall under the GMs umbrella,
>>> or ask Pierre if he wants to be the maintainer....
>>
>> I thought he already was the maintainer? Did we forget to send an
>> announcement when it happened? I can't find it...
>
> That's a good correction. He is, in fact, the Maintainer, since
> the end of March 2009. It probably flew under the radar because
> the script isn't in the same repo as GDB, I am not sure anymore.
>
> We should document this: Howzabout we start a MAINTAINERS file in
> the "ss" repo as well?
Fine with me, fwiw.
Didn't we talk at some point about moving the script over to the GDB
repo? It'd be nice to have it a bit more integrated with GDB so
people more easily run it locally..
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ARI patch] Fix gawk-4.0 warning
2012-03-15 15:52 ` Pedro Alves
@ 2012-03-15 16:21 ` Joel Brobecker
0 siblings, 0 replies; 6+ messages in thread
From: Joel Brobecker @ 2012-03-15 16:21 UTC (permalink / raw)
To: Pedro Alves; +Cc: Jan Kratochvil, muller, gdb-patches
> Didn't we talk at some point about moving the script over to the GDB
> repo? It'd be nice to have it a bit more integrated with GDB so
> people more easily run it locally..
I think this one can be moved, yeah. The others might be less useful
because they are just glue between the way things are stored on
sourceware, and the configure/Makefile code in GDB.
--
Joel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-03-15 16:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-14 20:15 [ARI patch] Fix gawk-4.0 warning Jan Kratochvil
2012-03-14 21:12 ` Joel Brobecker
2012-03-15 10:19 ` Pedro Alves
2012-03-15 15:25 ` Joel Brobecker
2012-03-15 15:52 ` Pedro Alves
2012-03-15 16:21 ` Joel Brobecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox