[patch/gdbserver] tracepoint log tweaks

[patch/gdbserver] tracepoint log tweaks

[Yao Qi]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

Hi,
When I read the comment here, I think we should write `stop_pc' in
stead of `tpoint->address' into log.  This patch is quite simple.  OK to
apply?

-- 
Yao (齐尧)

[-- Attachment #2: 0002-Write-stop_pc-in-log.patch --]
[-- Type: text/x-patch, Size: 749 bytes --]

gdb/gdbserver:
	* tracepoint.c (do_action_at_tracepoint): Write `stop_pc' in
	debug log.
---
 gdb/gdbserver/tracepoint.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gdb/gdbserver/tracepoint.c b/gdb/gdbserver/tracepoint.c
index baa9d94..7167876 100644
--- a/gdb/gdbserver/tracepoint.c
+++ b/gdb/gdbserver/tracepoint.c
@@ -4473,7 +4473,7 @@ do_action_at_tracepoint (struct tracepoint_hit_ctx *ctx,
 	   preemptively), since the PC had already been adjusted to
 	   contain the tracepoint's address by the jump pad.  */
 	trace_debug ("Storing stop pc (0x%s) in regblock",
-		     paddress (tpoint->address));
+		     paddress (stop_pc));
 
 	/* This changes the regblock, not the thread's
 	   regcache.  */
-- 
1.7.0.4

Re: [patch/gdbserver] tracepoint log tweaks

[Pedro Alves]

On 03/01/2012 03:37 PM, Yao Qi wrote:
> Hi,
> When I read the comment here, I think we should write `stop_pc' in
> stead of `tpoint->address' into log.  This patch is quite simple.  OK to
> apply?

Okay, thanks.

-- 
Pedro Alves