From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14808 invoked by alias); 1 Mar 2012 15:38:01 -0000 Received: (qmail 14730 invoked by uid 22791); 1 Mar 2012 15:37:59 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,FROM_12LTRDOM X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Mar 2012 15:37:40 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1S384Z-0001dG-VR from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Thu, 01 Mar 2012 07:37:39 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 1 Mar 2012 07:37:39 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Thu, 1 Mar 2012 07:37:38 -0800 Message-ID: <4F4F97C0.7030304@codesourcery.com> Date: Thu, 01 Mar 2012 15:38:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Subject: [patch/gdbserver] tracepoint log tweaks Content-Type: multipart/mixed; boundary="------------040908020203060403070003" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00019.txt.bz2 --------------040908020203060403070003 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Content-length: 169 Hi, When I read the comment here, I think we should write `stop_pc' in stead of `tpoint->address' into log. This patch is quite simple. OK to apply? -- Yao (齐尧) --------------040908020203060403070003 Content-Type: text/x-patch; name="0002-Write-stop_pc-in-log.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0002-Write-stop_pc-in-log.patch" Content-length: 749 gdb/gdbserver: * tracepoint.c (do_action_at_tracepoint): Write `stop_pc' in debug log. --- gdb/gdbserver/tracepoint.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gdb/gdbserver/tracepoint.c b/gdb/gdbserver/tracepoint.c index baa9d94..7167876 100644 --- a/gdb/gdbserver/tracepoint.c +++ b/gdb/gdbserver/tracepoint.c @@ -4473,7 +4473,7 @@ do_action_at_tracepoint (struct tracepoint_hit_ctx *ctx, preemptively), since the PC had already been adjusted to contain the tracepoint's address by the jump pad. */ trace_debug ("Storing stop pc (0x%s) in regblock", - paddress (tpoint->address)); + paddress (stop_pc)); /* This changes the regblock, not the thread's regcache. */ -- 1.7.0.4 --------------040908020203060403070003--