Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [patch/gdbserver] tracepoint log tweaks
Date: Thu, 01 Mar 2012 15:38:00 -0000	[thread overview]
Message-ID: <4F4F97C0.7030304@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

Hi,
When I read the comment here, I think we should write `stop_pc' in
stead of `tpoint->address' into log.  This patch is quite simple.  OK to
apply?

-- 
Yao (齐尧)

[-- Attachment #2: 0002-Write-stop_pc-in-log.patch --]
[-- Type: text/x-patch, Size: 749 bytes --]

gdb/gdbserver:
	* tracepoint.c (do_action_at_tracepoint): Write `stop_pc' in
	debug log.
---
 gdb/gdbserver/tracepoint.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gdb/gdbserver/tracepoint.c b/gdb/gdbserver/tracepoint.c
index baa9d94..7167876 100644
--- a/gdb/gdbserver/tracepoint.c
+++ b/gdb/gdbserver/tracepoint.c
@@ -4473,7 +4473,7 @@ do_action_at_tracepoint (struct tracepoint_hit_ctx *ctx,
 	   preemptively), since the PC had already been adjusted to
 	   contain the tracepoint's address by the jump pad.  */
 	trace_debug ("Storing stop pc (0x%s) in regblock",
-		     paddress (tpoint->address));
+		     paddress (stop_pc));
 
 	/* This changes the regblock, not the thread's
 	   regcache.  */
-- 
1.7.0.4


             reply	other threads:[~2012-03-01 15:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-01 15:38 Yao Qi [this message]
2012-03-01 15:48 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4F97C0.7030304@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox