From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 8/9] impl of use_agent and can_use_agent in linux-nat.
Date: Fri, 24 Feb 2012 14:34:00 -0000 [thread overview]
Message-ID: <4F479E5B.8090901@codesourcery.com> (raw)
In-Reply-To: <4F47970C.3090605@redhat.com>
On 02/24/2012 09:56 PM, Pedro Alves wrote:
> If the parameter didn't make sense in patch 1, but it makes sense in
> patch 8, then do the necessary adjustments to the code in patch 8,
> as if patch 1 was already applied. IOW, earlier patches
> on a series should stand on their own as much as possible. Yet IOW,
> if nothing uses the parameter in patch 1, then adding the parameter
> to the function should be done patch 8, where uses are added.
Right. They are very good principles on working on a set patches!
Pedro, thank you.
--
Yao (é½å°§)
next prev parent reply other threads:[~2012-02-24 14:29 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 2:56 [patch v2] GDB/GDBserver talks with agents Yao Qi
2012-02-17 2:56 ` [PATCH 3/9] command set agent on and off Yao Qi
2012-02-23 21:51 ` Pedro Alves
2012-02-24 13:13 ` Yao Qi
2012-02-24 14:15 ` Pedro Alves
2012-02-17 2:56 ` [PATCH 1/9] move agent related code from gdbserver to common/agent.c Yao Qi
2012-02-17 9:55 ` Mark Kettenis
2012-02-23 21:05 ` Pedro Alves
2012-02-23 21:17 ` Pedro Alves
2012-02-24 7:57 ` Yao Qi
2012-02-24 13:40 ` Yao Qi
2012-02-17 2:57 ` [PATCH 2/9] add target_ops fields use_agent and can_use_agent Yao Qi
2012-02-17 11:40 ` Eli Zaretskii
2012-02-23 21:21 ` Pedro Alves
2012-02-24 13:01 ` Yao Qi
2012-02-24 13:05 ` Pedro Alves
2012-02-17 2:57 ` [PATCH 4/9] agent doc Yao Qi
2012-02-17 11:38 ` Eli Zaretskii
2012-02-17 13:34 ` Yao Qi
2012-02-17 16:10 ` Pedro Alves
2012-02-18 17:11 ` Eli Zaretskii
2012-02-20 3:56 ` Yao Qi
2012-02-20 6:22 ` Eli Zaretskii
2012-02-21 18:18 ` Pedro Alves
2012-02-22 1:56 ` Yao Qi
2012-02-22 20:41 ` Pedro Alves
2012-02-22 23:43 ` Eli Zaretskii
2012-02-27 13:23 ` Yao Qi
2012-02-17 2:57 ` [PATCH 5/9] agent capability Yao Qi
2012-02-17 2:57 ` [PATCH 7/9] move in_process_agent_loaded to agent_loaded_p Yao Qi
2012-02-23 22:11 ` Pedro Alves
2012-02-23 22:27 ` Pedro Alves
2012-02-17 2:57 ` [PATCH 8/9] impl of use_agent and can_use_agent in linux-nat Yao Qi
2012-02-23 22:15 ` Pedro Alves
2012-02-24 8:34 ` Yao Qi
2012-02-24 10:47 ` Pedro Alves
2012-02-24 13:31 ` Yao Qi
2012-02-24 14:10 ` Pedro Alves
2012-02-24 14:34 ` Yao Qi [this message]
2012-02-17 2:57 ` [PATCH 6/9] agent capability of static tracepoint Yao Qi
2012-02-23 22:06 ` Pedro Alves
2012-02-24 13:19 ` Yao Qi
2012-02-24 14:25 ` Pedro Alves
2012-02-17 3:02 ` [PATCH 9/9] info static tracepoint in linux-nat Yao Qi
2012-02-24 13:37 ` Yao Qi
2012-02-17 4:02 ` [patch v2] GDB/GDBserver talks with agents Yao Qi
2012-02-17 12:03 ` Eli Zaretskii
2012-02-27 9:43 ` Yao Qi
2012-02-27 18:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F479E5B.8090901@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox