From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1331 invoked by alias); 24 Feb 2012 14:29:05 -0000 Received: (qmail 1322 invoked by uid 22791); 24 Feb 2012 14:29:04 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Feb 2012 14:28:49 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1S0w8e-00073h-0v from Yao_Qi@mentor.com ; Fri, 24 Feb 2012 06:28:48 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 24 Feb 2012 06:28:43 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Fri, 24 Feb 2012 06:28:45 -0800 Message-ID: <4F479E5B.8090901@codesourcery.com> Date: Fri, 24 Feb 2012 14:34:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0) Gecko/20120130 Thunderbird/10.0 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH 8/9] impl of use_agent and can_use_agent in linux-nat. References: <1329447300-18841-1-git-send-email-yao@codesourcery.com> <1329447300-18841-9-git-send-email-yao@codesourcery.com> <4F46B981.5070108@redhat.com> <4F478E15.1080703@codesourcery.com> <4F47970C.3090605@redhat.com> In-Reply-To: <4F47970C.3090605@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00568.txt.bz2 On 02/24/2012 09:56 PM, Pedro Alves wrote: > If the parameter didn't make sense in patch 1, but it makes sense in > patch 8, then do the necessary adjustments to the code in patch 8, > as if patch 1 was already applied. IOW, earlier patches > on a series should stand on their own as much as possible. Yet IOW, > if nothing uses the parameter in patch 1, then adding the parameter > to the function should be done patch 8, where uses are added. Right. They are very good principles on working on a set patches! Pedro, thank you. -- Yao (齐尧)