Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: [ping 2]: [PATCH] Fix that different function breakpoints are set at same pc address  (PR gdb/12703)
Date: Sun, 09 Oct 2011 15:06:00 -0000	[thread overview]
Message-ID: <4E91B870.4020105@codesourcery.com> (raw)
In-Reply-To: <4E81A8FC.3070905@codesourcery.com>

On 09/27/2011 06:44 PM, Yao Qi wrote:
>   http://sourceware.org/ml/gdb-patches/2011-06/msg00370.html
> 
> I regression tested this patch on armv7l-unknown-linux-gnueabi with
> {-mthumb, -marm}, no new fails.  OK for mainline?
> 

Ping again.

>> > 	gdb/
>> > 	* arm-tdep.c (thumb_analyze_prologue): Check condition for 32-bit
>> > 	Thumb-2 instructions. 
>> > 
>> > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
>> > index 2dd8c9e..7f5a0e1 100644
>> > --- a/gdb/arm-tdep.c
>> > +++ b/gdb/arm-tdep.c
>> > @@ -832,8 +832,9 @@ thumb_analyze_prologue (struct gdbarch *gdbarch,
>> >  	  constant = read_memory_unsigned_integer (loc, 4, byte_order);
>> >  	  regs[bits (insn, 8, 10)] = pv_constant (constant);
>> >  	}
>> > -      else if ((insn & 0xe000) == 0xe000)
>> > +      else if ((insn & 0xe000) == 0xe000 && (insn & 0x1800) != 0)
>> >  	{
>> > +	  /* 32-bit Thumb-2 instructions.  */
>> >  	  unsigned short inst2;
>> >  
>> >  	  inst2 = read_memory_unsigned_integer (start + 2, 2,


-- 
Yao (齐尧)


  reply	other threads:[~2011-10-09 15:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-24  2:31 Terry Guo
2011-06-24  3:55 ` Yao Qi
2011-06-24  8:59   ` Pedro Alves
2011-06-24 10:39     ` Yao Qi
2011-09-27 12:53       ` [ping]: " Yao Qi
2011-10-09 15:06         ` Yao Qi [this message]
2011-10-10 14:47       ` [PATCH] Fix that different function breakpoints are set@same " Ulrich Weigand
2011-10-12  0:47         ` Yao Qi
2011-10-12 11:58           ` Ulrich Weigand
2011-10-13  8:19             ` [committed] : " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E91B870.4020105@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox