From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: yao@codesourcery.com (Yao Qi)
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix that different function breakpoints are set@same pc address (PR gdb/12703)
Date: Mon, 10 Oct 2011 14:47:00 -0000 [thread overview]
Message-ID: <201110101446.p9AEklVX022612@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <4E04692F.3030500@codesourcery.com> from "Yao Qi" at Jun 24, 2011 06:38:39 PM
Yao Qi wrote:
> gdb/
> * arm-tdep.c (thumb_analyze_prologue): Check condition for 32-bit
> Thumb-2 instructions.
Huh. That check is indeed wrong.
> - else if ((insn & 0xe000) == 0xe000)
> + else if ((insn & 0xe000) == 0xe000 && (insn & 0x1800) != 0)
> {
Instead of open-coding the check, I think it would be preferable to
use the thumb_insn_size routine instead.
Note that there are a number of other places that either already open-
code the correct check, or -worse- use the same incorrect check as the
code above:
- thumb_in_function_epilogue_p
- thumb_get_next_pc_raw
- arm_breakpoint_from_pc
Would you mind converting them all to thumb_insn_size?
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2011-10-10 14:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 2:31 [PATCH] Fix that different function breakpoints are set at same " Terry Guo
2011-06-24 3:55 ` Yao Qi
2011-06-24 8:59 ` Pedro Alves
2011-06-24 10:39 ` Yao Qi
2011-09-27 12:53 ` [ping]: " Yao Qi
2011-10-09 15:06 ` [ping 2]: " Yao Qi
2011-10-10 14:47 ` Ulrich Weigand [this message]
2011-10-12 0:47 ` [PATCH] Fix that different function breakpoints are set@same " Yao Qi
2011-10-12 11:58 ` Ulrich Weigand
2011-10-13 8:19 ` [committed] : " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110101446.p9AEklVX022612@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox