From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Yao Qi <yao@codesourcery.com>
Subject: Re: [PATCH] Fix that different function breakpoints are set at same pc address (PR gdb/12703)
Date: Fri, 24 Jun 2011 08:59:00 -0000 [thread overview]
Message-ID: <201106240959.08358.pedro@codesourcery.com> (raw)
In-Reply-To: <4E040A9A.5020807@codesourcery.com>
On Friday 24 June 2011 04:55:06, Yao Qi wrote:
> On 06/24/2011 10:30 AM, Terry Guo wrote:
>
> IMO, this is a target-specific bug, so this PR's component should be
> tdept, so it should be "PR tdept/12703" instead of "PR gdb/12703".
>
> I'd move your test cases break-function.{c,exp} to gdb.arch/ dir,
> because it is target-dependent fix. I am sure this case is useful to
> other ports.
The testcase might help catch the same issue in other archs.
IMO, it should stay generic if possible.
I agree with Yao when he says in the PR that there seems to be
some other root cause for the bug. Shouldn't
thumb_instruction_changes_pc have caught that "b.n" ?
00008160 <fault_isr>:
8160: e7fe b.n 8160 <fault_isr>
...
00008164 <reset_isr>:
8164: 4a05 ldr r2, [pc, #20] ; (817c <reset_isr+0x18>)
> > +void foo(void)
>
> This doesn't comply to GNU coding standard. Please move "foo ()" to
> next line.
Note that test code does not strictly _need_ to follow the
coding standards. Though it's indeed nice when it does.
GDB should be able to debug non-GNU code too. :-)
--
Pedro Alves
next prev parent reply other threads:[~2011-06-24 8:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 2:31 Terry Guo
2011-06-24 3:55 ` Yao Qi
2011-06-24 8:59 ` Pedro Alves [this message]
2011-06-24 10:39 ` Yao Qi
2011-09-27 12:53 ` [ping]: " Yao Qi
2011-10-09 15:06 ` [ping 2]: " Yao Qi
2011-10-10 14:47 ` [PATCH] Fix that different function breakpoints are set@same " Ulrich Weigand
2011-10-12 0:47 ` Yao Qi
2011-10-12 11:58 ` Ulrich Weigand
2011-10-13 8:19 ` [committed] : " Yao Qi
2011-06-27 11:26 [PATCH] Fix that different function breakpoints are set at same " Terry Guo
2011-06-29 1:26 ` Terry Guo
2011-06-29 5:36 ` Yao Qi
2011-06-29 7:00 ` Terry Guo
2011-06-29 8:00 ` Yao Qi
2011-06-29 8:49 ` Terry Guo
[not found] ` <45520D6299C11E4588128526465332BB0D0C8B1246@SAROVARA.Asiapac.Arm.com>
2011-06-29 10:00 ` Yao Qi
2011-06-29 10:17 ` Terry Guo
2011-07-01 8:59 ` Richard Earnshaw
2011-07-01 9:47 ` Pedro Alves
2011-07-13 13:21 ` Terry Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106240959.08358.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox