From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4539 invoked by alias); 9 Oct 2011 15:06:58 -0000 Received: (qmail 4531 invoked by uid 22791); 9 Oct 2011 15:06:58 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,FROM_12LTRDOM X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 09 Oct 2011 15:06:32 +0000 Received: from nat-jpt.mentorg.com ([192.94.33.2] helo=PR1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RCuxT-0003YM-Ru from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Sun, 09 Oct 2011 08:06:32 -0700 Received: from [127.0.0.1] ([172.16.63.104]) by PR1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 10 Oct 2011 00:06:30 +0900 Message-ID: <4E91B870.4020105@codesourcery.com> Date: Sun, 09 Oct 2011 15:06:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: [ping 2]: [PATCH] Fix that different function breakpoints are set at same pc address (PR gdb/12703) References: <000001cc3216$b96ba290$2c42e7b0$@guo@arm.com> <4E040A9A.5020807@codesourcery.com> <201106240959.08358.pedro@codesourcery.com> <4E04692F.3030500@codesourcery.com> <4E81A8FC.3070905@codesourcery.com> In-Reply-To: <4E81A8FC.3070905@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00224.txt.bz2 On 09/27/2011 06:44 PM, Yao Qi wrote: > http://sourceware.org/ml/gdb-patches/2011-06/msg00370.html > > I regression tested this patch on armv7l-unknown-linux-gnueabi with > {-mthumb, -marm}, no new fails. OK for mainline? > Ping again. >> > gdb/ >> > * arm-tdep.c (thumb_analyze_prologue): Check condition for 32-bit >> > Thumb-2 instructions. >> > >> > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c >> > index 2dd8c9e..7f5a0e1 100644 >> > --- a/gdb/arm-tdep.c >> > +++ b/gdb/arm-tdep.c >> > @@ -832,8 +832,9 @@ thumb_analyze_prologue (struct gdbarch *gdbarch, >> > constant = read_memory_unsigned_integer (loc, 4, byte_order); >> > regs[bits (insn, 8, 10)] = pv_constant (constant); >> > } >> > - else if ((insn & 0xe000) == 0xe000) >> > + else if ((insn & 0xe000) == 0xe000 && (insn & 0x1800) != 0) >> > { >> > + /* 32-bit Thumb-2 instructions. */ >> > unsigned short inst2; >> > >> > inst2 = read_memory_unsigned_integer (start + 2, 2, -- Yao (齐尧)