From: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: [committed]: [patch] Skip kill-after-signal.exp if hw single-step is not supported
Date: Sun, 18 Sep 2011 10:22:00 -0000 [thread overview]
Message-ID: <4E755A61.5020909@codesourcery.com> (raw)
In-Reply-To: <20110918001057.GA11805@adacore.com>
On 09/18/2011 08:10 AM, Joel Brobecker wrote:
>> gdb/testsuite/
>>
>> * lib/gdb.exp (single_step_to_signal_handler_p): New.
>> * gdb.base/kill-after-signal.exp: Skip if target supports single step
>> to signal handler.
>
> No one commented on this patch.
>
> I only have minor comments, so pre-approved with those changes.
>
Joel, thanks for the review.
>
> Can you name the function "can_single_step_to_signal_handler" instead?
> I think it will be a little clearer what this function is about.
>
OK.
> Also, your comments, both in the function description as well as
> inside the function itself, are a little two wide. We have a soft-limit
> of 70 chars, which can be exceeded if it helps readability.
>
OK, I re-format comments a little bit to comply to 70-char limit.
Committed.
http://sourceware.org/ml/gdb-cvs/2011-09/msg00114.html
--
Yao (é½å°§)
next prev parent reply other threads:[~2011-09-18 2:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 14:52 Yao Qi
2011-07-20 15:06 ` Jan Kratochvil
2011-07-20 15:12 ` Pedro Alves
2011-07-24 11:40 ` Mark Kettenis
2011-08-09 14:32 ` Yao Qi
2011-08-09 15:24 ` Matthew Gretton-Dann
2011-08-09 15:50 ` Yao Qi
2011-08-18 4:53 ` ping : " Yao Qi
2011-08-28 14:44 ` Yao Qi
2011-09-14 7:18 ` ping 3: " Yao Qi
2011-09-18 2:42 ` Joel Brobecker
2011-09-18 10:22 ` Yao Qi [this message]
2011-07-23 23:28 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E755A61.5020909@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox