From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12886 invoked by alias); 18 Sep 2011 02:42:04 -0000 Received: (qmail 12863 invoked by uid 22791); 18 Sep 2011 02:42:02 -0000 X-SWARE-Spam-Status: No, hits=-0.5 required=5.0 tests=AWL,BAYES_00,FROM_12LTRDOM,MISSING_HEADERS X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 18 Sep 2011 02:41:46 +0000 Received: from nat-jpt.mentorg.com ([192.94.33.2] helo=PR1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1R57KD-0001jx-Tk from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Sat, 17 Sep 2011 19:41:46 -0700 Received: from [172.30.8.113] ([172.30.8.113]) by PR1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Sun, 18 Sep 2011 11:41:44 +0900 Message-ID: <4E755A61.5020909@codesourcery.com> Date: Sun, 18 Sep 2011 10:22:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 MIME-Version: 1.0 CC: gdb-patches@sourceware.org Subject: [committed]: [patch] Skip kill-after-signal.exp if hw single-step is not supported References: <4E259815.8080001@codesourcery.com> <201107201605.43767.pedro@codesourcery.com> <201107232247.p6NMlwVx029216@glazunov.sibelius.xs4all.nl> <4E414503.7080201@codesourcery.com> <20110918001057.GA11805@adacore.com> In-Reply-To: <20110918001057.GA11805@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00347.txt.bz2 On 09/18/2011 08:10 AM, Joel Brobecker wrote: >> gdb/testsuite/ >> >> * lib/gdb.exp (single_step_to_signal_handler_p): New. >> * gdb.base/kill-after-signal.exp: Skip if target supports single step >> to signal handler. > > No one commented on this patch. > > I only have minor comments, so pre-approved with those changes. > Joel, thanks for the review. > > Can you name the function "can_single_step_to_signal_handler" instead? > I think it will be a little clearer what this function is about. > OK. > Also, your comments, both in the function description as well as > inside the function itself, are a little two wide. We have a soft-limit > of 70 chars, which can be exceeded if it helps readability. > OK, I re-format comments a little bit to comply to 70-char limit. Committed. http://sourceware.org/ml/gdb-cvs/2011-09/msg00114.html -- Yao (齐尧)