Re: [patch] Skip kill-after-signal.exp if hw single-step is not supported

[Yao Qi <yao@codesourcery.com>]

On 08/09/2011 11:24 PM, Matthew Gretton-Dann wrote:
> Would this be better if it followed the pattern of the
> skip_hw_breakpoint_tests and skip_hw_watchpoint_tests family of
> functions in gdb.exp?
> 
> So I would rename the function to skip_hw_single_step_tests[1], and test
> for the existence of gdb,no_hardware_watchpoints in the board info.
> 

Personally, I don't like the procs' name skip_* in lib/gdb.exp.  IMO,
procs in lib/gdb.exp of this kind is to check a certain property in
current env, and return the result.  Leave the test case itself to
determine whether to skip or run.

"single_step_to_signal_handler_p" is not equivalent to "hardware single
step",  because some targets have hardware single step, but can't step
into signal handler.

The property interested here is "whether we can single step into a
signal handler", instead of "whether target has hardware single step".
I am not good at naming functions, so ideas on a better/clear name is
welcome.

-- 
Yao (齐尧)