Re: [PATCH] gdb.python/py-evthreads.exp: fix racy test (PR testsuite/12649)

[Marek Polacek <mpolacek@redhat.com>]

On 07/06/2011 07:26 PM, Joel Brobecker wrote:
>> It is a difference as it requires the end of the read buffer that way.
>>
>> If GDB outputs some
>> (gdb) unexpected_result
>>
>> then (without any read1 hacks) -re "$gdb_prompt $" will FAIL/timeout as it
>> should while -re "$gdb_prompt " could give a false PASS.
>>
>> (I do not think it requires a new commit, it is up to you.)
> 
> Let's fix it. If anything, we should be consistent. I might have
> a minute later today, but I don't want to make the change without
> running the testcase... So, I won't mind if someone gets to it before
> I do.
> 

Sure.  Shall I commit the patch below?

2011-07-06  Marek Polacek  <mpolacek@redhat.com>

	* gdb.python/py-evthreads.exp: Add missing `$'.

--- gdb/gdb/testsuite/gdb.python/py-evthreads.exp.mp	2011-07-06 19:34:05.210582529 +0200
+++ gdb/gdb/testsuite/gdb.python/py-evthreads.exp	2011-07-06 19:34:14.660516229 +0200
@@ -86,7 +86,7 @@ gdb_expect {
 send_gdb "continue&\n"
 gdb_expect {
     -re ".*event type: continue.*
-.*thread num: 1.*\r\n$gdb_prompt " {
+.*thread num: 1.*\r\n$gdb_prompt $" {
         pass "continue thread 1"
     }
     timeout {