From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Marek Polacek <mpolacek@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb.python/py-evthreads.exp: fix racy test (PR testsuite/12649)
Date: Wed, 06 Jul 2011 17:21:00 -0000 [thread overview]
Message-ID: <20110706171145.GB28535@host1.jankratochvil.net> (raw)
In-Reply-To: <4E0C4F28.4000703@redhat.com>
On Thu, 30 Jun 2011 12:25:44 +0200, Marek Polacek wrote:
> On 06/28/2011 05:51 PM, Joel Brobecker wrote:
> > This is an area where I'm not entirely sure, but we usually use
> > `$gdb_prompt $' as the anchor.
>
> Actually, it doesn't matter. That `$' at the end marks end of the
> read buffer, not the end of line.
It is a difference as it requires the end of the read buffer that way.
If GDB outputs some
(gdb) unexpected_result
then (without any read1 hacks) -re "$gdb_prompt $" will FAIL/timeout as it
should while -re "$gdb_prompt " could give a false PASS.
(I do not think it requires a new commit, it is up to you.)
Thanks,
Jan
next prev parent reply other threads:[~2011-07-06 17:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 14:19 Marek Polacek
2011-06-28 15:51 ` Joel Brobecker
2011-06-30 10:26 ` Marek Polacek
2011-07-06 17:21 ` Jan Kratochvil [this message]
2011-07-06 17:32 ` Joel Brobecker
2011-07-06 17:57 ` Marek Polacek
2011-07-06 19:53 ` Jan Kratochvil
2011-07-06 22:06 ` Marek Polacek
2011-07-06 14:36 ` Marek Polacek
2011-07-06 14:51 ` Joel Brobecker
2011-07-06 15:46 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706171145.GB28535@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mpolacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox